Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run CPU-only unit tests automatically for pull requests #873

Merged
merged 7 commits into from
May 14, 2024

Conversation

dyastremsky
Copy link
Contributor

@dyastremsky dyastremsky commented May 9, 2024

This pull request adds an automation to automatically run unit tests for new pull requests. It checks them against Python 3.8 and 3.11. I updated the supported Python versions to be aligned with those supported in PyTriton, Triton CLI, and GenAI-Perf, especially since Ubuntu 22.04 only supports 3.9+.

The automation uses unittest-parallel to speed up the running of unit tests. I also added the mypy cache to gitignore to avoid accidentally committing those files.

You can see the results in the new jobs that are running for this PR.

@dyastremsky dyastremsky requested a review from nv-braf May 9, 2024 18:59
@dyastremsky dyastremsky self-assigned this May 9, 2024
@dyastremsky dyastremsky changed the title Run unit tests automatically for pull requests Run CPU-only unit tests automatically for pull requests May 9, 2024
Copy link
Contributor

@nv-braf nv-braf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@dyastremsky dyastremsky merged commit cd456dd into main May 14, 2024
5 checks passed
@dyastremsky dyastremsky deleted the dyas-unittest-automation branch May 14, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants