Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Connect up parameter description class #869
Connect up parameter description class #869
Changes from 2 commits
0eb267d
80ad325
9f603a4
3944a25
7f68735
0d3b47a
16ac9d8
4383bdc
b63b635
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This logic appears to be very trusting that things are done right elsewhere. Do we want to add safeguards?
If a parameter list is passed, do the RCS values get silently ignored? I thought all four parameters (including parameter_list) are passed elsewhere, which means the RCS values would be ignored. If a parameter list is not passed, it feels like the error is a bit misleading, since what if it's not passed but the parameter isn't supposed to be exponential/linear. I think some refactoring needs to be done here. I think this can exist as one function, but with increased documentation to understand what is happening and safeguarding to prevent logic errors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rule is that if the user specifies a list then we use that, else we use RCS values to create a min/max search space.
I've added a comment to reflect this.