Capture LLM metrics from genai-perf in MA #844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
tgerdesnv
reviewed
Mar 21, 2024
tgerdesnv
reviewed
Mar 21, 2024
tgerdesnv
approved these changes
Mar 22, 2024
nv-braf
added a commit
that referenced
this pull request
Apr 8, 2024
* Successfully reading from LLM CSV * General cleanup * All unit tests passing * Fixing metric table typos * Fixing typos
nv-braf
added a commit
that referenced
this pull request
Apr 8, 2024
* New Records for LLM metrics (#839) * Adding new LLM metrics * Adding base class for perf, inter_token, and time_to_first latency records * Add --llm-mode option (#842) * Adding CLI hook for LLM * Changing to use --model-type * Capture LLM metrics from genai-perf in MA (#844) * Successfully reading from LLM CSV * General cleanup * All unit tests passing * Fixing metric table typos * Fixing typos * Update constraints for LLMs (#845) * Adding LLM values to list of possible constraints * Fixing typo * Adding new output fields for LLM (#846) * Profiling model using genai-perf (#849) * Initial changes to run genai-perf in MA * Gating call to get LLM records * Fixing captilization issue * Removing debug * Adding TODO --------- Co-authored-by: root <[email protected]> * Add genai_perf CLI options to MA (#854) * Added support for genai_perf CLI * Remove dead code * Removing genai_perf collateral * Fixing codeQL issue * Adding streaming to genai_perf_config --------- Co-authored-by: root <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding methods to capture new LLM metrics from genai-perf.
Unit testing in place as well as a small refactoring of the testing.
I've also added in the extra metrics (p95, p50, p25).