Fix incorrect remote mode warnings #828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the incorrect warning in
server_factory.py(we now have control of the model in remote mode).The check for models already loaded was incorrect. The repository index is just a list of models that could be loaded, not what is currently loaded.
After getting the list of potential models, I've added a call to
is_model_ready()which will only return true if the model is actually loaded.No easy way to unit test this (it probably needs an L0, but that seems overkill for a warning message), but I have run it locally and confirmed that the warning messages both go away and then come back if I load a model on the server before running MA.