Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DCGM version to 3.2.6 #785

Merged
merged 14 commits into from
Nov 6, 2023
Merged

Update DCGM version to 3.2.6 #785

merged 14 commits into from
Nov 6, 2023

Conversation

nv-hwoo
Copy link
Contributor

@nv-hwoo nv-hwoo commented Nov 3, 2023

Should merge together with: triton-inference-server/server#6515

@nv-hwoo nv-hwoo requested review from mc-nv and nv-braf November 3, 2023 16:45
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CodeQL found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.

Copy link
Contributor

@nv-braf nv-braf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as it's passing the CI I'm fine with these changes and I believe we should just waive the codeQL errors.

@mc-nv mc-nv requested a review from nv-braf November 3, 2023 20:13
@kthui kthui requested a review from dyastremsky November 3, 2023 21:58
Copy link
Contributor

@dyastremsky dyastremsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful work!

@nv-hwoo nv-hwoo merged commit 167278f into main Nov 6, 2023
2 of 3 checks passed
@nv-hwoo nv-hwoo deleted the mchornyi-dcgm-v3 branch November 6, 2023 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants