Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix windows build #391

Merged
merged 1 commit into from
Aug 21, 2024
Merged

fix: Fix windows build #391

merged 1 commit into from
Aug 21, 2024

Conversation

yinggeh
Copy link
Contributor

@yinggeh yinggeh commented Aug 21, 2024 •
edited
Loading

What does the PR do?

Fix windows build
New C APIs were added in #386 but some were not added in to core/src/tritonserver_stub.cc.

Checklist

  • PR title reflects the change and is of format <commit_type>: <Title>
  • Changes are described in the pull request.
  • Related issues are referenced.
  • Populated github labels field
  • Added test plan and verified test passes.
  • Verified that the PR passes existing CI.
  • Verified copyright is correct on all changed files.
  • Added succinct git squash message before merging ref.
  • All template sections are filled out.
  • Optional: Additional screenshots for behavior/output changes with before/after.

Commit Type:

Check the conventional commit type
box here and add the label to the github PR.

  • fix

Related PRs:

n/a

Where should the reviewer start?

n/a

Test plan:

n/a

  • CI Pipeline ID:
    17686949

Caveats:

n/a

Background

n/a

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

n/a

@yinggeh yinggeh added the bug Something isn't working label Aug 21, 2024
@yinggeh yinggeh requested a review from mc-nv August 21, 2024 00:08
@yinggeh yinggeh self-assigned this Aug 21, 2024
@yinggeh yinggeh requested review from tanmayv25 and statiraju and removed request for tanmayv25 and statiraju August 21, 2024 00:16
statiraju
statiraju previously approved these changes Aug 21, 2024
View reviewed changes
tanmayv25
tanmayv25 previously approved these changes Aug 21, 2024
View reviewed changes
@yinggeh yinggeh changed the base branch from main to r24.08 August 21, 2024 00:21
@yinggeh yinggeh dismissed stale reviews from tanmayv25 and statiraju August 21, 2024 00:21

The base branch was changed.

@yinggeh yinggeh force-pushed the yinggeh-fix-windows-build branch 2 times, most recently from 17664da to c7ef453 Compare August 21, 2024 00:39
@mc-nv
Copy link
Contributor

mc-nv commented Aug 21, 2024

It must went to the main first and be cherry-picked after.

@yinggeh yinggeh changed the base branch from r24.08 to main August 21, 2024 00:49
@yinggeh
Copy link
Contributor Author

yinggeh commented Aug 21, 2024

It must went to the main first and be cherry-picked after.

Reverted and set this PR to merge to main.

@yinggeh
Copy link
Contributor Author

yinggeh commented Aug 21, 2024

@tanmayv25 Should we consider auto-generate core/src/tritonserver_stub.cc?

@yinggeh yinggeh merged commit 13b6046 into main Aug 21, 2024
1 check passed
yinggeh added a commit that referenced this pull request Aug 21, 2024
@yinggeh
Fix windows build (#391)
04687f7
mc-nv pushed a commit that referenced this pull request Aug 21, 2024
@yinggeh
Fix windows build (#391) (#392)
5d199b6
@yinggeh yinggeh deleted the yinggeh-fix-windows-build branch August 29, 2024 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanmayv25 tanmayv25 tanmayv25 approved these changes

@mc-nv mc-nv Awaiting requested review from mc-nv

@statiraju statiraju Awaiting requested review from statiraju

Assignees

@yinggeh yinggeh

Labels
bug Something isn't working
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yinggeh @mc-nv @tanmayv25 @statiraju