Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lock grpcio version #811

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Lock grpcio version #811

merged 1 commit into from
Nov 21, 2024

Conversation

mc-nv
Copy link
Contributor

@mc-nv mc-nv commented Nov 20, 2024 •
edited
Loading

Intro:

Without this upper version limit model we getting issue where Model Analyzer is unable to reach grpc endpoint.

@kthui
Copy link
Contributor

kthui commented Nov 20, 2024 •
edited
Loading

Hi @krishung5 @rmccorm4, do you have any concern if the gRPC version on the client is newer than the one on the server?

The server is currently on 1.54.3, and this change will set the version on the client to 1.67.1

@rmccorm4
Copy link
Contributor

rmccorm4 commented Nov 20, 2024 •
edited
Loading

Hi @krishung5 @rmccorm4, do you have any concern if the gRPC version on the client is newer than the one on the server?

The server is currently on 1.54.3, and this change will set the version on the client to 1.67.1

@kthui The current client version specification before this change (>=1.63.0) is already higher than the server version you pointed to, and hasn't given us any issues I'm aware of, so I have no issue with this change.

However, @mc-nv can you add details on the reason/context in the Description of these types of PRs so in the future looking backwards we can better understand why this change was made?

Also linking related PR: triton-inference-server/model_analyzer#946

@kthui kthui self-requested a review November 20, 2024 22:37
@mc-nv mc-nv marked this pull request as ready for review November 21, 2024 03:15
@mc-nv mc-nv mentioned this pull request Nov 21, 2024
Merged
@mc-nv mc-nv merged commit a77904d into r24.11 Nov 21, 2024
3 checks passed
@mc-nv mc-nv deleted the mchornyi-24.11-grpcio branch November 21, 2024 20:34
mc-nv added a commit that referenced this pull request Nov 22, 2024
@mc-nv
Lock grpcio version (#811)
a9fb94b
mc-nv added a commit that referenced this pull request Nov 26, 2024
@mc-nv @nv-anants @yinggeh
Update main branch post 24.11 (#812)
76e15f2 
* Build Updates for Ubuntu24.04 (#802) (#805)

* update cmake version

* include patch version in cmake install

Co-authored-by: Anant Sharma <[email protected]>

* Hotfix for java (#808)

* Prevent failure if cache is empty (#809)

* Lock grpcio version (#811)

* fix: Partial fix for L0_https (#810)

* Fix L0_https--base SSL issue (#813)

* Upgrade geventhttpclient version to 2.3.2

* Upgrade geventhttpclient to latest version

---------

Co-authored-by: Anant Sharma <[email protected]>
Co-authored-by: Yingge He <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nv-braf nv-braf nv-braf approved these changes

@krishung5 krishung5 krishung5 approved these changes

@kthui kthui kthui approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mc-nv @kthui @rmccorm4 @krishung5 @nv-braf