Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cuda linking bug #801

Merged
merged 1 commit into from
Oct 25, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/c++/examples/CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Copyright 2020-2022, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
# Copyright 2020-2024, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
#
# Redistribution and use in source and binary forms, with or without
# modification, are permitted provided that the following conditions
Expand Down Expand Up @@ -271,7 +271,7 @@ if(TRITON_ENABLE_CC_GRPC)
simple_grpc_cudashm_client
PRIVATE
grpcclient_static
${CUDA_LIBRARIES}
CUDA::cudart
)
matthewkotila marked this conversation as resolved.
Show resolved Hide resolved
install(
TARGETS simple_grpc_cudashm_client
Expand Down Expand Up @@ -409,7 +409,7 @@ if(TRITON_ENABLE_CC_HTTP)
simple_http_cudashm_client
PRIVATE
httpclient_static
${CUDA_LIBRARIES}
CUDA::cudart
)
install(
TARGETS simple_http_cudashm_client
Expand Down
12 changes: 4 additions & 8 deletions src/c++/library/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -291,10 +291,8 @@ if(TRITON_ENABLE_CC_GRPC)
endif() # TRITON_ENABLE_GPU

if(TRITON_ENABLE_GPU)
target_link_libraries(
${_client_target}
PUBLIC CUDA::cudart
)
target_include_directories(${_client_target}
PUBLIC ${CUDAToolkit_INCLUDE_DIRS})
matthewkotila marked this conversation as resolved.
Show resolved Hide resolved
endif() # TRITON_ENABLE_GPU
endforeach()

Expand Down Expand Up @@ -477,10 +475,8 @@ if(TRITON_ENABLE_CC_HTTP)
endif() # TRITON_ENABLE_GPU

if(TRITON_ENABLE_GPU)
target_link_libraries(
${_client_target}
PUBLIC CUDA::cudart
)
target_include_directories(${_client_target}
PUBLIC ${CUDAToolkit_INCLUDE_DIRS})
matthewkotila marked this conversation as resolved.
Show resolved Hide resolved
endif() # TRITON_ENABLE_GPU

if(${TRITON_ENABLE_ZLIB})
Expand Down
Loading