Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Bump tritonclient deps to grpcio>=1.63.0 and protobuf>=5.26.1,<6 #788

Merged
merged 3 commits into from
Oct 12, 2024

Conversation

tonyay163
Copy link
Contributor

Fixes #787

@kthui
Copy link
Contributor

kthui commented Oct 10, 2024

Pipeline: 19226487

@rmccorm4 rmccorm4 changed the title Bump tritonclient grpcio dep build: Bump tritonclient deps to grpcio>=1.63.0 and protobuf>=5.26.1,<6 Oct 11, 2024
@tonyay163
Copy link
Contributor Author

@GuanLuo @rmccorm4 @kthui, do you mind clicking merge for me and kicking off a release? I'm unfortunately missing permissions !

@kthui kthui merged commit 85d4471 into triton-inference-server:main Oct 12, 2024
3 checks passed
@kthui
Copy link
Contributor

kthui commented Oct 12, 2024

@tonyay163 this is going into r24.11. Is it ok?

@tonyay163
Copy link
Contributor Author

@kthui, what's the python package version for that? It looks like the latest is 2.50.0 right now

@kthui
Copy link
Contributor

kthui commented Oct 14, 2024

@tonyay163 The latest release for Python gRPC is 1.66.2 / 1.67.0
https://pypi.org/project/grpcio/#history
https://github.com/grpc/grpc/releases

@tonyay163
Copy link
Contributor Author

what does that have to do with tritonclient? it doesn't go into Python gRPC? I just want to know what version I should expect to pick up this fix in tritonclient's Python package and when we can expect that to be released

@kthui
Copy link
Contributor

kthui commented Oct 14, 2024

I just want to know what version I should expect to pick up this fix in tritonclient's Python package and when we can expect that to be released

The fix is going to be picked up by version 2.52.0 (release 24.11)

@tonyay163
Copy link
Contributor Author

Thank you ! Do you have an estimate when it will be released?

@kthui
Copy link
Contributor

kthui commented Oct 14, 2024

Around the end of November.

@tonyay163
Copy link
Contributor Author

@kthui, is it possible to hotfix this into 2.50 or 2.51 to unblock me?

@kthui
Copy link
Contributor

kthui commented Oct 15, 2024

2.50 is unlikely because it is already released. We are looking into 2.51 / 24.10. cc @statiraju

@tonyay163
Copy link
Contributor Author

or maybe 2.50.1 as a hotfix?

@kthui
Copy link
Contributor

kthui commented Oct 16, 2024

Unfortunately, the 2.51 / 24.10 branch was frozen last Monday. The change will go into 2.52.0 / 24.11. You might want to reach out to your support contact if this is too late.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

tritonclient protobuf / grpcio version mismatch
3 participants