-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Treat HTTP request completion as final response #748
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have a quick repro/test we could do to the see the effect e.g. with the generate endpoint? We might want to add a CI test to verify this behavior.
will require further changes to support I'm good either way |
For HTTP streaming endpoints which do not explicitly send a
[DONE]
message, updated to treat the HTTP request completion as a final response.This is backwards compatible and doesn't effect endpoints that do explicitly send
[DONE]
.This is one change needed for Triton Generate as well as some TGI interfaces / servers.
Checks are added to ensure only a single final response is sent.