-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] LLaVA support #720
Merged
Merged
[WIP] LLaVA support #720
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
06df643
POC for LLaVA support
mwawrzos 20fe487
non-streaming request in VLM tests
mwawrzos dfb6b1d
image component sent in "image_url" field instead of HTML tag
mwawrzos 819cd90
generate sample image instead of loading from docs
mwawrzos e805a92
add vision to endpoint mapping
mwawrzos f0a87f0
Merge branch 'main' into mwawrzos/openai-vision
nv-hwoo 8bf2710
fixes for handling OutputFormat
mwawrzos 0ced8b3
refactor - extract image preparation to a separate module
mwawrzos eea4c26
fixes to the refactor
mwawrzos b03a6a6
replace match-case syntax with if-elseif-else
mwawrzos d46d8fb
Update image payload format and fix tests
nv-hwoo 5d1e7d2
Few clean ups and tickets added for follow up tasks
nv-hwoo 9f20592
Fix and add tests for vision format
nv-hwoo b82bf40
Remove output format from profile data parser
nv-hwoo 2346a40
Revert irrelevant code change
nv-hwoo 7c0de7f
Revert changes
nv-hwoo 773a140
Remove unused dependency
nv-hwoo fa61742
Comment test_extra_inputs
nv-hwoo 8c9c078
Merge branch 'vision-language' into mwawrzos/openai-vision
nv-hwoo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
92 changes: 0 additions & 92 deletions
92
src/c++/perf_analyzer/genai-perf/genai_perf/test_end_to_end.py
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -59,6 +59,7 @@ dependencies = [ | |
"pytest-mock", | ||
"pyyaml", | ||
"responses", | ||
"pillow", | ||
] | ||
|
||
# CLI Entrypoint | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The response format for chat VLMs is the same as the regular chat completion since we just have text out, why have a separate entry?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The name of the enum is a bit misleading 😅 The
OutputFormat
enum is actually not about the format of the response but it's about the format of the resulting input json file by LlmInputs.