Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update GenAi-PA formatting for throughput and streaming metrics #503

Merged
merged 6 commits into from
Mar 8, 2024
Merged

Update GenAi-PA formatting for throughput and streaming metrics #503

merged 6 commits into from
Mar 8, 2024

Conversation

dyastremsky
Copy link
Contributor

Updates the formatting for GenAi-PA:

  1. For throughput metrics, show 2 significant figures.
  2. For throughput metrics, only one value matters. Take these metrics out of the main table.
  3. For the streaming case, time to first token and response latency are the same, so do not show time to first token.

New format for output table:
image

New format for CSV export:
image

@dyastremsky dyastremsky changed the title Update formatting for GenAi-PA Update GenAi-PA formatting for singular and streaming metrics Mar 8, 2024
@dyastremsky dyastremsky changed the title Update GenAi-PA formatting for singular and streaming metrics Update GenAi-PA formatting for throughput and streaming metrics Mar 8, 2024
@dyastremsky dyastremsky merged commit 1926cd0 into feature-genai-pa Mar 8, 2024
3 checks passed
@dyastremsky dyastremsky deleted the dyas-single-metrics branch March 8, 2024 19:04
debermudez pushed a commit that referenced this pull request Mar 12, 2024
@dyastremsky @debermudez
Update GenAi-PA formatting for throughput and streaming metrics (#503)
c6f2549
debermudez pushed a commit that referenced this pull request Mar 13, 2024
@dyastremsky @debermudez
Update GenAi-PA formatting for throughput and streaming metrics (#503)
7435f60
mc-nv pushed a commit that referenced this pull request Mar 13, 2024
@dyastremsky @mc-nv
Update GenAi-PA formatting for throughput and streaming metrics (#503)
36b4f71
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@debermudez debermudez debermudez approved these changes

@tgerdesnv tgerdesnv Awaiting requested review from tgerdesnv

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dyastremsky @debermudez