Fix divide by zero and unit conversion for throughput display #500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nv-hwoo
commented
Mar 8, 2024
nv-hwoo
commented
- When calculating ITL, set number of token to default to 1 when the response is empty (for now)
- Convert latency units from nanosecond to second in order to avoid near-zero throughput metrics.
dyastremsky
approved these changes
Mar 8, 2024
debermudez
pushed a commit
that referenced
this pull request
Mar 12, 2024
* Fix divide by zero * Convert ns to secs for throughput metrics
debermudez
pushed a commit
that referenced
this pull request
Mar 13, 2024
* Fix divide by zero * Convert ns to secs for throughput metrics
mc-nv
pushed a commit
that referenced
this pull request
Mar 13, 2024
* Fix divide by zero * Convert ns to secs for throughput metrics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.