Export GenAi-PA results to CSV file #497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
…/client into dyas-csv
debermudez
reviewed
Mar 7, 2024
| @@ -85,6 +85,10 @@ def report_output(metrics: LLMProfileDataParser, args): | |||
| "Neither concurrency_range nor request_rate_range was found in args when reporting metrics" | |||
| ) | |||
| stats = metrics.get_statistics(infer_mode, int(load_level)) | |||
| export_csv_name = args.profile_export_file.with_name( | |||
| args.profile_export_file.stem + "_genai_pa" + args.profile_export_file.suffix | |||
There was a problem hiding this comment.
Needs to be .csv not .json
debermudez
reviewed
Mar 7, 2024
| "generated. By default, the profile export will be to profile_export.json. " | ||
| "The GenAi-PA file will be exported to <profile_export_file>_genai_pa.<file_extension>. " | ||
| "For example, if the profile export file is profile_export.json, the GenAi-PA file will be " | ||
| "exported to profile_export_genai_pa.json.", |
There was a problem hiding this comment.
csv file right? not json?
debermudez
approved these changes
Mar 7, 2024
nv-hwoo
reviewed
Mar 7, 2024
nv-hwoo
approved these changes
Mar 7, 2024
debermudez
pushed a commit
that referenced
this pull request
Mar 12, 2024
debermudez
pushed a commit
that referenced
this pull request
Mar 13, 2024
mc-nv
pushed a commit
that referenced
this pull request
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request cleans up the GenAi-PA report table and exports the more detailed metrics to a CSV (e.g. more percentile options).
Since we are requiring the export file due to PA returning it, this clarifies the wording. For simplicity, since the PA export is being saved, the GenAi-PA one will be as well. If we remove the PA export file being written in the future, we can also look at making the GenAi-PA CSV being optional for users who want to disable the exports.
Report with highlights shown (excluding inter-token latency due to this being with streaming disabled):
CSV with all calculated percentiles shown (excluding inter-token latency due to this being with streaming disabled):
