Add formatting for GenAi-PA report #491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dyastremsky
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
rmccorm4
reviewed
Mar 6, 2024
debermudez
reviewed
Mar 6, 2024
|
Updated to this format based on the discussion above and some offline discussion. We may remove some of the percentile columns if we decide to optionally output the data to a file: |
rmccorm4
reviewed
Mar 7, 2024
|
|
||
| console = Console() | ||
| console.print(table) | ||
|
|
||
| field_stats = {} |
There was a problem hiding this comment.
Thanks for catching this! I missed some of the old implementation code. It should be cleaner now. :)
rmccorm4
reviewed
Mar 7, 2024
debermudez
approved these changes
Mar 7, 2024
debermudez
pushed a commit
that referenced
this pull request
Mar 12, 2024
debermudez
pushed a commit
that referenced
this pull request
Mar 13, 2024
mc-nv
pushed a commit
that referenced
this pull request
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request formats the printed metrics produced by GenAi-PA. While we only have two metrics so far, it aims to future-proof metrics so that there is less work as new metrics are added.
Note that the below output seems to be wrong (the number of seconds is too high). This pull request is only focused on formatting. The computation will either be in a separate ticket or be added here later, if the team decides that is easier.
Output:
