Add additional Cli parsing #474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmccorm4
reviewed
Feb 27, 2024
rmccorm4
reviewed
Feb 27, 2024
rmccorm4
reviewed
Feb 27, 2024
rmccorm4
reviewed
Feb 27, 2024
rmccorm4
reviewed
Feb 27, 2024
rmccorm4
reviewed
Feb 27, 2024
debermudez
commented
Feb 28, 2024
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
…s, updated version option behavior, cleaned up code
debermudez
force-pushed
the
dbermudez-cli-parser
branch
from
80849d1 to
d660e9d
Compare
rmccorm4
reviewed
Feb 28, 2024
rmccorm4
reviewed
Feb 28, 2024
rmccorm4
reviewed
Feb 28, 2024
rmccorm4
reviewed
Feb 28, 2024
rmccorm4
reviewed
Feb 28, 2024
rmccorm4
reviewed
Feb 28, 2024
rmccorm4
reviewed
Feb 28, 2024
Comment on lines
+110
to
+117
| # TODO: necessary? | ||
| # parser.add_argument( | ||
| # "--output-length", | ||
| # type=int, | ||
| # default=128, | ||
| # required=False, | ||
| # help="The output length (tokens) to use for benchmarking LLMs. (Default: 128)", | ||
| # ) |
There was a problem hiding this comment.
Assuming we'll clean up these comments blocks and unused dataset_args and stuff in later follow-up PRs
rmccorm4
approved these changes
Feb 28, 2024
nv-braf
pushed a commit
that referenced
this pull request
Feb 29, 2024
* Adding subprocess call and more arg parsing * Add url option * Remove input length option * Update help messages, mistakes in args, removed sync and async options, updated version option behavior, cleaned up code * Refactored code to clean things up * Use metavar and dest in cli to help with url option
debermudez
added a commit
that referenced
this pull request
Mar 12, 2024
* Adding subprocess call and more arg parsing * Add url option * Remove input length option * Update help messages, mistakes in args, removed sync and async options, updated version option behavior, cleaned up code * Refactored code to clean things up * Use metavar and dest in cli to help with url option
debermudez
added a commit
that referenced
this pull request
Mar 13, 2024
* Adding subprocess call and more arg parsing * Add url option * Remove input length option * Update help messages, mistakes in args, removed sync and async options, updated version option behavior, cleaned up code * Refactored code to clean things up * Use metavar and dest in cli to help with url option
mc-nv
pushed a commit
that referenced
this pull request
Mar 13, 2024
* Adding subprocess call and more arg parsing * Add url option * Remove input length option * Update help messages, mistakes in args, removed sync and async options, updated version option behavior, cleaned up code * Refactored code to clean things up * Use metavar and dest in cli to help with url option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifying parser code to fit the args elevated to PA.
Handle args that need massaging between PA core and GenAI-PA.
Make the subprocess call.