Draft unit testing framework #470
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| return device_attribute | ||
|
|
||
| @staticmethod | ||
| def dcgmGroupCreate(dcgm_handle, type_name, name): |
Check notice
Code scanning / CodeQL
Explicit returns mixed with implicit (fall through) returns Note test
* Add boilerplate code with placeholder for running PA * Add return value for codeql
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is not meant to go in on its own. This branch is a placeholder to see if we want this structure for unit testing.
These files are copied from Model Analyzer until there is time to create a testing infrastructure specific to perf analyzer.
Note that I'll probably remove files for the MVP. For now, this leaves in all the mocks and tests that could be good for initial design. Once the initial tests are written, we can remove any that are unnecessary.