Pr/387 #465
Merged
Pr/387 #465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgerdesnv
reviewed
Feb 2, 2024
| grpc_channel_stub_map_.insert( | ||
| std::make_pair(url, std::make_tuple(1, channel, stub))); | ||
|
|
||
| if (use_cached_channel) { |
There was a problem hiding this comment.
I wouldn't expect testing changes to change production code. Is this needed?
There was a problem hiding this comment.
This change is coming from here: #387
I do not know what are process is for PRs without testing so made a branch from the external PR, added testing and made sure the commit shows the original contributors github handle.
Tabrizian
reviewed
Feb 6, 2024
src/c++/tests/cc_client_test.cc
Outdated
| const tc::KeepAliveOptions& keepalive_options = tc::KeepAliveOptions(); | ||
| bool use_cached_channel = false; | ||
| auto err = tc::InferenceServerGrpcClient::Create( | ||
| &this->client_, url, verbose, use_ssl, ssl_options, keepalive_options, |
There was a problem hiding this comment.
Is there a way we could re-use the ClientTest?
src/c++/tests/cc_client_test.cc
Outdated
| @@ -1615,6 +1709,58 @@ TEST_F(GRPCTraceTest, GRPCClearTraceSettings) | |||
| << std::endl; | |||
| } | |||
|
|
|||
| TEST_F(GRPCClientTest, InferMultiNoUseCachedChannel) | |||
There was a problem hiding this comment.
Is there are reason we're using InferMulti instead of regular Infer calls?
|
Cannot approve since I am considered original author. All of this looks good to me. |
Tabrizian
approved these changes
Apr 16, 2024
jbkyang-nvi
added a commit
to triton-inference-server/server
that referenced
this pull request
Apr 17, 2024
debermudez
added a commit
that referenced
this pull request
Apr 18, 2024
Adding testing to verify new use_cached_channel behavior. To be merged after #387 Server test: triton-inference-server/server#7123 --------- Co-authored-by: Markus Hennerbichler <[email protected]> Co-authored-by: Katherine Yang <[email protected]> Co-authored-by: Katherine Yang <[email protected]>
mc-nv
pushed a commit
that referenced
this pull request
Apr 18, 2024
Adding testing to verify new use_cached_channel behavior. To be merged after #387 Server test: triton-inference-server/server#7123 --------- Co-authored-by: Markus Hennerbichler <[email protected]> Co-authored-by: Katherine Yang <[email protected]> Co-authored-by: Katherine Yang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding testing to verify new use_cached_channel behavior.
To be merged after #387
Server test: triton-inference-server/server#7123