Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more detailed metrics to the LLM benchmarks #431

Merged
merged 15 commits into from
Nov 7, 2023
Merged

Conversation

nv-hwoo
Copy link
Contributor

@nv-hwoo nv-hwoo commented Nov 3, 2023

Few changes

  1. Support both online & offline LLM benchmarks (default is online)
  2. Add more detailed metrics for latencies and throughputs

Users can run offline LLM benchmark by either setting --offline flag or setting "STREAM" input tensor to false through input JSON file.

Some new metrics added are

  • Max/min first token latency
  • p50/p90/p95/p99 first token latency
  • Avg/max/min generation latency
  • p50/p90/p95/p99 generation latency
  • Avg token latency
  • Avg/max/min end-to-end latency
  • Avg/max/min token throughput
  • p50/p90/p95/p99 token throughput
  • etc

Copy link
Contributor

@matthewkotila matthewkotila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done with my review. Looks pretty good overall. Thanks for working on this, Hyunjae 🙏

@nv-hwoo nv-hwoo requested a review from matthewkotila November 6, 2023 22:41
@nv-hwoo nv-hwoo requested a review from matthewkotila November 7, 2023 00:44
@nv-hwoo nv-hwoo merged commit 7afa27a into main Nov 7, 2023
3 checks passed
@nv-hwoo nv-hwoo deleted the hwoo-llm-offline branch November 7, 2023 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants