Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the benchmark script for more modular codebase as well as to give users more flexibility on specifying input tensors or sampling parameters through either input data JSON file or command line when running benchmarks.
Before the change, if users wanted to sweep through generated prompts, they had to manually specify parameters (e.g. max tokens) through command line without providing input data JSON file. This was to avoid conflicts in the code. However, this limited users to use input data JSON file only when they were using custom prompt.
Now, users can use both input data JSON file and command line to specify parameters regardless of whether or not they want to sweep through prompts or use custom prompts. For instance, users can use
*When using both command line and input JSON file to specify parameters, if any parameter overlaps, the value specified in the command line will overwrite the one in the input JSON file.