Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the LLM benchmark script #427

Merged
merged 7 commits into from
Oct 28, 2023
Merged

Refactor the LLM benchmark script #427

merged 7 commits into from
Oct 28, 2023

Conversation

nv-hwoo
Copy link
Contributor

@nv-hwoo nv-hwoo commented Oct 26, 2023

Refactor the benchmark script for more modular codebase as well as to give users more flexibility on specifying input tensors or sampling parameters through either input data JSON file or command line when running benchmarks.

Before the change, if users wanted to sweep through generated prompts, they had to manually specify parameters (e.g. max tokens) through command line without providing input data JSON file. This was to avoid conflicts in the code. However, this limited users to use input data JSON file only when they were using custom prompt.

Now, users can use both input data JSON file and command line to specify parameters regardless of whether or not they want to sweep through prompts or use custom prompts. For instance, users can use

  • input JSON only to set sampling parameters and generate prompt
  • both command line & input JSON to set sampling parameters and generate prompt
  • command line only to set sampling parameters and generate prompt
  • input JSON to fix prompt (no prompt generation)

*When using both command line and input JSON file to specify parameters, if any parameter overlaps, the value specified in the command line will overwrite the one in the input JSON file.

Copy link
Contributor

@debermudez debermudez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple questions around your format calls. otherwise looks good.

@nv-hwoo nv-hwoo merged commit ab8ac0c into main Oct 28, 2023
3 checks passed
@nv-hwoo nv-hwoo deleted the hwoo-refactor branch October 28, 2023 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants