-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve metric and generate plot for in-flight batch size benchmark #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nv-hwoo
changed the title
Improve metric and generate output plot for continuous batch size benchmark
Improve metric and generate plot for continuous batch size benchmark
Oct 17, 2023
nv-hwoo
changed the title
Improve metric and generate plot for continuous batch size benchmark
Improve metric and generate plot for in-flight batch size benchmark
Oct 17, 2023
dyastremsky
reviewed
Oct 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Added a few nits and clarifying questions for the documentation.
@dyastremsky Updated the doc. Let me know if it's any better. It's probably easier to read by looking at the updated doc on the branch rather than the diff. |
dyastremsky
reviewed
Oct 24, 2023
nv-hwoo
requested review from
dyastremsky and
matthewkotila
and removed request for
matthewkotila
October 26, 2023 06:40
dyastremsky
approved these changes
Oct 26, 2023
matthewkotila
approved these changes
Oct 26, 2023
nv-hwoo
force-pushed
the
hwoo-llm-metric
branch
from
October 26, 2023 18:31
54a4a09
to
0bec02e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.