Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve metric and generate plot for in-flight batch size benchmark #422

Merged
merged 17 commits into from
Oct 26, 2023

Conversation

nv-hwoo
Copy link
Contributor

@nv-hwoo nv-hwoo commented Oct 17, 2023

No description provided.

@nv-hwoo nv-hwoo changed the title Improve metric and generate output plot for continuous batch size benchmark Improve metric and generate plot for continuous batch size benchmark Oct 17, 2023
@nv-hwoo nv-hwoo requested a review from matthewkotila October 17, 2023 15:52
@nv-hwoo nv-hwoo changed the title Improve metric and generate plot for continuous batch size benchmark Improve metric and generate plot for in-flight batch size benchmark Oct 17, 2023
@nv-hwoo nv-hwoo requested a review from matthewkotila October 18, 2023 21:10
@nv-hwoo nv-hwoo requested a review from matthewkotila October 19, 2023 17:10
Copy link
Contributor

@dyastremsky dyastremsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Added a few nits and clarifying questions for the documentation.

src/c++/perf_analyzer/docs/llm.md Outdated Show resolved Hide resolved
src/c++/perf_analyzer/docs/llm.md Outdated Show resolved Hide resolved
src/c++/perf_analyzer/docs/llm.md Outdated Show resolved Hide resolved
src/c++/perf_analyzer/docs/llm.md Outdated Show resolved Hide resolved
@nv-hwoo
Copy link
Contributor Author

nv-hwoo commented Oct 24, 2023

@dyastremsky Updated the doc. Let me know if it's any better. It's probably easier to read by looking at the updated doc on the branch rather than the diff.

@nv-hwoo nv-hwoo requested review from dyastremsky and matthewkotila and removed request for matthewkotila October 26, 2023 06:40
@nv-hwoo nv-hwoo merged commit 6748079 into main Oct 26, 2023
3 checks passed
@nv-hwoo nv-hwoo deleted the hwoo-llm-metric branch October 26, 2023 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants