Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix L0_grpc #400

Merged
merged 1 commit into from
Sep 21, 2023
Merged

Fix L0_grpc #400

merged 1 commit into from
Sep 21, 2023

Conversation

tanmayv25
Copy link
Contributor

rpc_error.cancelled is True for restricted RPCs as well.

@tanmayv25 tanmayv25 merged commit bcf8cad into request-cancellation Sep 21, 2023
@tanmayv25 tanmayv25 deleted the tanmayv-fix branch September 21, 2023 21:24
return InferenceServerException(
msg="Locally cancelled by application!", status="StatusCode.CANCELLED"
)
if msg == None:

Check notice

Code scanning / CodeQL

Testing equality to None

Testing for None should use the 'is' operator.
tanmayv25 added a commit that referenced this pull request Oct 4, 2023
* Supporting client-side gRPC cancellation (#393)

* Supporting client-side gRPC cancellation

* Address review comments

* Wrap future to expose only cancel

* Update src/python/library/tritonclient/grpc/_client.py

Co-authored-by: Iman Tabrizian <[email protected]>

* Reverting changes in asyncio library

* Format

* Make class variable real private

---------

Co-authored-by: Iman Tabrizian <[email protected]>

* Fix L0_grpc (#400)

* Improve the check

---------

Co-authored-by: Iman Tabrizian <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant