Skip to content

Commit

Permalink
Enabling Ninja build
Browse files Browse the repository at this point in the history
The current setup for the libgrpcclient.ldscript file may work fine with GNU make at the moment, but confuses [Ninja](https://ninja-build.org/). This will fix the build for Ninja, while hopefully letting the rest of the build work when using the GNU Makefile generator.
  • Loading branch information
nicolasnoble authored Oct 11, 2024
1 parent cb9ba08 commit 6490bec
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/c++/library/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ if(TRITON_ENABLE_CC_GRPC)
#
# libgrpcclient.so and libgrpcclient_static.a
#
configure_file(libgrpcclient.ldscript libgrpcclient.ldscript COPYONLY)
configure_file(libgrpcclient.ldscript ${CMAKE_CURRENT_BINARY_DIR}/libgrpcclient.ldscript COPYONLY)

# libgrpcclient object build
set(
Expand Down Expand Up @@ -245,7 +245,7 @@ if(TRITON_ENABLE_CC_GRPC)
grpcclient
PROPERTIES
LINK_DEPENDS ${CMAKE_CURRENT_BINARY_DIR}/libgrpcclient.ldscript
LINK_FLAGS "-Wl,--version-script=libgrpcclient.ldscript"
LINK_FLAGS "-Wl,--version-script=${CMAKE_CURRENT_BINARY_DIR}/libgrpcclient.ldscript"
)
endif() # NOT WIN32 AND NOT TRITON_KEEP_TYPEINFO

Expand Down

0 comments on commit 6490bec

Please sign in to comment.