-
Notifications
You must be signed in to change notification settings - Fork 0
Add board header #287
base: v2
Are you sure you want to change the base?
Add board header #287
Conversation
minamorl
commented
Mar 30, 2023
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Not sure why Chromatic deployment is failing though. I'll look into it
I think the issue is with the I'm not sure if this is why the Chromatic build is failing, but I'm going to try removing the file and see if that fixes it. |
File was causing git checkout error and issues with Chromatic deployment
There still seems to be an issue with the Chromatic Storybook build, related to the TailwindCSS installation (missing files for some reason). Looking into it. |
Chaged default board image implementation to inline styling to fix reference to public url
I fixed the storybook build (the reference to public url in tailwind was causing an error with storybook, so I put the public url reference in some inline styling and it works now). But, the default header background isn't loading (in Chromatic or locally). The default board icon (the Tenet logo) is loading fine, so I'm not sure what the problem is. |