Skip to content
This repository has been archived by the owner on Apr 16, 2023. It is now read-only.

Add board header #287

Open
wants to merge 4 commits into
base: v2
Choose a base branch
from
Open

Add board header #287

wants to merge 4 commits into from

Conversation

minamorl
Copy link
Contributor

image

@minamorl minamorl requested a review from SharmaMitchell March 30, 2023 03:21
@vercel
Copy link

vercel bot commented Mar 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
coton ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 30, 2023 at 7:26PM (UTC)

Copy link
Contributor

@SharmaMitchell SharmaMitchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Not sure why Chromatic deployment is failing though. I'll look into it

@SharmaMitchell
Copy link
Contributor

I think the issue is with the :Zone.Identifier file. I'm getting a git error when I try to checkout to the branch, because this is a protected file type that isn't supposed to be committed.
(stackoverflow post for reference: https://stackoverflow.com/questions/66702176/error-invalid-path-filepathzone-identifier#:~:text=it%20is%20not%20supposed%20to%20be%20committed)

I'm not sure if this is why the Chromatic build is failing, but I'm going to try removing the file and see if that fixes it.

File was causing git checkout error and issues with Chromatic deployment
@SharmaMitchell
Copy link
Contributor

There still seems to be an issue with the Chromatic Storybook build, related to the TailwindCSS installation (missing files for some reason). Looking into it.

Chaged default board image implementation to inline styling to fix reference to public url
@SharmaMitchell
Copy link
Contributor

SharmaMitchell commented Mar 30, 2023

I fixed the storybook build (the reference to public url in tailwind was causing an error with storybook, so I put the public url reference in some inline styling and it works now). But, the default header background isn't loading (in Chromatic or locally). The default board icon (the Tenet logo) is loading fine, so I'm not sure what the problem is.
Can you look into it? @minamorl
EDIT: I'm thinking it may be an issue with the public directory in general, maybe try importing the images from a separate assets directory 🤔

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants