-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: % support #8
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me - do you think it's worth adding a test now or good to wait until more dev has been done on the feature?
I am planning to add a test shortly, but i am just waiting until I finish a couple of minor type def/API changes which are in the other open PR |
still checking this out. looks good so far. re: "only supports brackets at the moment", the |
Thanks. I'm not sure how much more of the implementation I want to recreate at this stage. I have decided that I want to where possible avoid using the vim functions and use lua implementations of their behaviour. As a |
I think that I am happy with this level of implementation I will give it some time to mull over, but then i think this can get merged |
early days implementation
needs:
testsdocsconsideration about support when not directly over the bracket
only supports brackets at the moment
middlebracket support for if/else/endcomment supportwill close #3
and part of #5