Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add optional debounce #55

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: add optional debounce #55

wants to merge 2 commits into from

Conversation

willothy
Copy link
Collaborator

@willothy willothy commented Jun 1, 2024

No description provided.

@willothy willothy requested a review from tris203 June 1, 2024 18:01
tris203
tris203 requested changes Jun 1, 2024
View reviewed changes
Copy link
Owner

@tris203 tris203 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Obviously take a look at the failing test too

lua/precognition/init.lua Outdated Show resolved Hide resolved
@willothy willothy requested a review from tris203 June 1, 2024 19:07
tris203
tris203 requested changes Jun 1, 2024
View reviewed changes
Copy link
Owner

@tris203 tris203 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it, we will just need docs and this will be a 1.1 feature

@tris203 tris203 added this to the 1.1.0 milestone Jun 1, 2024
@tris203 tris203 force-pushed the debounced branch 2 times, most recently from d5a2179 to 0957223 Compare June 3, 2024 20:34
@willothy willothy self-assigned this Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tris203 tris203 tris203 requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@willothy willothy

Labels
None yet
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@willothy @tris203