fix: a lot of edge cases #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willothy
approved these changes
May 3, 2024
refactor(tests): refactor into seperate files
|
This is how I want it to be, however there is one regex I cant get right, or think how to refactor to work The vertical motions will find the next blank lines, not the ones preceding/following content @willothy perhaps you might have an idea? It is the tests that are commented with TODO comments and they use the two paragraph functions in |
willothy
requested changes
May 3, 2024
|
Interface looks great! |
|
Not sure if I'll get to the paragraph motions tonight so maybe best to leave that out of this and I'll make another PR tomorrow? |
I think this is finally ready to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2
and a few edge cases reported on reddit