Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass additional options to JVM (WIP) #505

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Pass additional options to JVM (WIP) #505

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions helm/trino-gateway/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,12 +43,7 @@ spec:
image: "{{ .Values.image.repository }}:{{ .Values.image.tag | default .Chart.AppVersion }}"
imagePullPolicy: {{ .Values.image.pullPolicy }}
command:
- "java"
- "-XX:MinRAMPercentage=80.0"
- "-XX:MaxRAMPercentage=80.0"
- "-jar"
- "/usr/lib/trino/gateway-ha-jar-with-dependencies.jar"
- "/etc/gateway/config.yaml"
{{- toYaml .Values.command | nindent 12}}
ports:
- name: request
containerPort: {{ index .Values "config" "serverConfig" "http-server.http.port" }}
Expand Down
9 changes: 9 additions & 0 deletions helm/trino-gateway/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,15 @@ config:
managedApps:
- io.trino.gateway.ha.clustermonitor.ActiveClusterMonitor

# Startup command for Trino Gateway process. Add additional java options here if required
command:
- "java"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two space indent like in below or four like above.. maybe we should make the whole file consistent

- "-XX:MinRAMPercentage=80.0"
- "-XX:MaxRAMPercentage=80.0"
- "-jar"
- "/usr/lib/trino/gateway-ha-jar-with-dependencies.jar"
- "/etc/gateway/config.yaml"

service:
type: ClusterIP
port: 8080
Expand Down