Implement DECIMAL type and remove DOUBLE type to conform with TPCH spec #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kokosing
reviewed
Aug 1, 2018
| @@ -79,7 +79,7 @@ public String getString(Part part) | |||
| }, | |||
|
|
|||
| @SuppressWarnings("SpellCheckingInspection") | |||
| RETAIL_PRICE("p_retailprice", DOUBLE) | |||
| RETAIL_PRICE("p_retailprice", DECIMAL) | |||
| { | |||
| public double getDouble(Part part) | |||
There was a problem hiding this comment.
is this method needed? I would expect getLong here.
There was a problem hiding this comment.
I left the method here for completeness sake. Do you want to remove getDouble from here?
| @@ -23,7 +23,7 @@ | |||
| INTEGER, | |||
| IDENTIFIER, | |||
| DATE, | |||
| DOUBLE, | |||
| DECIMAL, | |||
There was a problem hiding this comment.
can you add a comment that it precision = 2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.