Expose unscaled numeric values #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
related issue prestodb/presto#3557 |
|
Can you rename the currency ones to |
sopel39
force-pushed
the
tpch-unscaled
branch
from
7a73351
to
0a182c6
Compare
|
@dain I have updated the commit, please take a look |
| public double getDiscount() | ||
| { | ||
| return discount / 100.0; | ||
| } | ||
|
|
||
| public long getDiscountUnscaled() |
There was a problem hiding this comment.
This should be getDiscountPercent.
Unscaled numeric values are used to build decimal values in TPCH connector.
sopel39
force-pushed
the
tpch-unscaled
branch
from
0a182c6
to
594f8ec
Compare
|
@dain fixed |
|
Merged, thanks! |
|
Do you need any other changes before I release? |
|
That's the only non-Presto change, thanks. |
|
This is released as 0.5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unscaled numeric values are used to build decimal values in TPCH connector.