Add spec values to coordinator and worker deployments #236
Conversation
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
|
I sent the signed CLA on 9/26 😃 |
|
The CLAs are processed every two weeks or so. If you've already sent it, don't worry about it, I'll keep an eye on them |
| {{- if .Values.coordinator.deployment.progressDeadlineSeconds }} | ||
| progressDeadlineSeconds: {{ .Values.coordinator.deployment.progressDeadlineSeconds }} | ||
| {{- end }} | ||
| {{- if or .Values.coordinator.deployment.revisionHistoryLimit (eq 0 .Values.coordinator.deployment.revisionHistoryLimit) }} |
There was a problem hiding this comment.
It might be easier to read this condition if it checked if the value is not an empty string
There was a problem hiding this comment.
Sounds good.
Important thing to notice here is that, if the user sets revisionHistoryLimit: 0 then they explicitly want to clean up all history.
However in Helm, having foo: 0 is treated as if omitted.
We could either do:
{{- if (ne "" .Values.coordinator.deployment.revisionHistoryLimit) }}(maybe the easiest to read){{- if not (eq "" .Values.coordinator.deployment.revisionHistoryLimit) }}
There was a problem hiding this comment.
Maybe it would be best to have a non-nil default? K8s docs say the default for revisionHistoryLimit is 10.
This is my first PR and I did not know about that. Let me address your comments |
| @@ -47,6 +47,11 @@ secretMounts: | |||
| path: /etc/trino/certificates | |||
|
|
|||
| coordinator: | |||
| deployment: | |||
| progressDeadlineSeconds: ~ | |||
There was a problem hiding this comment.
Also @nineinchnick , not sure how you want to test this new values?
Do you want me to add some specific values here? It does not seems that you guys testing Deployment Spec diffs.
There was a problem hiding this comment.
- Just a basic smoke test that Trino deploys with these values set
There was a problem hiding this comment.
Set values here that are different than the defaults.
Adding deployment spec values for
coordinatordeployment andworkerdeployment:This is needed for us in case of an update of Trino Cluster that requires the deployment to bring pods up and down.