Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I turned
TestPresigningHeaders
andTestPresignedRequests
into abstract test classes, so unfortunately this results in a large diff. Diffing these files with theirAbstract
counterparts should provide useful insight.This PR introduces functionality to redirect the bucket and key of an S3 request, in order to provide a virtualised view of a bucket.
Since the proxy does not decode the responses it gets back from S3, listing files or listing buckets will result in the real names being returned.
The authorisation logic happens with the original bucket and key and not the rewritten one. I believe this is a powerful way of letting users build abstractions on top of existing storage buckets, but it would need to be documented to ensure people understand how request rewriting changes the authorization flow.