Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add strict signature validation of aws-chunked streams #130

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

vagaerg
Copy link
Member

@vagaerg vagaerg commented Aug 1, 2024

Closes #102

Ensure we never return x-amz-decoded-content-length bytes without having verified the signatures.

This should protect us from:

  • Chunks overreporting their size so that we send x-amz-decoded-content-length before validating the signature (as the proxy did not know the chunk had finished)
  • Chunks containing more data than they report
  • Mismatched declared and actual content lengths

@cla-bot cla-bot bot added the cla-signed label Aug 1, 2024
@vagaerg vagaerg merged commit a00969b into trinodb:main Aug 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Illegal chunk signatures do not prevent files from getting uploaded to S3
2 participants