-
Notifications
You must be signed in to change notification settings - Fork 4
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Refactor TestHttpCredentialsProvider
- Loading branch information
Showing
4 changed files
with
222 additions
and
133 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
82 changes: 82 additions & 0 deletions
82
...st/java/io/trino/aws/proxy/server/credentials/http/TestHttpCredentialsProviderServer.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,82 @@ | ||
| /* | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package io.trino.aws.proxy.server.credentials.http; | ||
|
|
||
| import com.google.common.collect.ImmutableMap; | ||
| import io.airlift.http.server.HttpServerConfig; | ||
| import io.airlift.http.server.HttpServerInfo; | ||
| import io.airlift.http.server.testing.TestingHttpServer; | ||
| import io.airlift.node.NodeInfo; | ||
| import io.trino.aws.proxy.server.testing.TestingIdentity; | ||
| import io.trino.aws.proxy.server.testing.TestingTrinoAwsProxyServer; | ||
| import io.trino.aws.proxy.server.testing.harness.BuilderFilter; | ||
| import jakarta.servlet.Servlet; | ||
|
|
||
| import java.io.IOException; | ||
| import java.util.Map; | ||
|
|
||
| import static io.trino.aws.proxy.server.credentials.http.HttpCredentialsModule.HTTP_CREDENTIALS_PROVIDER_IDENTIFIER; | ||
| import static io.trino.aws.proxy.spi.plugin.TrinoAwsProxyServerBinding.bindIdentityType; | ||
|
|
||
| public class TestHttpCredentialsProviderServer | ||
| { | ||
| protected TestHttpCredentialsProviderServer() {} | ||
|
|
||
| public static class Filter | ||
| implements BuilderFilter | ||
| { | ||
| private static String httpEndpointUri; | ||
|
|
||
| @Override | ||
| public TestingTrinoAwsProxyServer.Builder filter(TestingTrinoAwsProxyServer.Builder builder) | ||
| { | ||
| TestingHttpServer httpCredentialsServer; | ||
| Map<String, String> expectedHeaders = ImmutableMap.<String, String>builder() | ||
| .put("Authorization", "some-auth") | ||
| .put("Content-Type", "application/json") | ||
| .put("Some-Dummy-Header", "test,value") | ||
| .buildOrThrow(); | ||
| String headerConfigAsString = "Authorization: some-auth, Content-Type: application/json, Some-Dummy-Header:test,,value"; | ||
|
|
||
| TestHttpCredentialsServlet httpCredentialsServlet; | ||
| try { | ||
| httpCredentialsServlet = new TestHttpCredentialsServletImpl(expectedHeaders); | ||
| httpCredentialsServer = createTestingHttpCredentialsServer(httpCredentialsServlet); | ||
| httpCredentialsServer.start(); | ||
| httpEndpointUri = httpCredentialsServer.getBaseUrl().toString(); | ||
| } | ||
| catch (Exception e) { | ||
| throw new RuntimeException("Failed to start test http credentials provider server", e); | ||
| } | ||
| return builder.withoutTestingCredentialsRoleProviders() | ||
| .addModule(new HttpCredentialsModule()) | ||
| .addModule(binder -> bindIdentityType(binder, TestingIdentity.class)) | ||
| .withProperty("credentials-provider.type", HTTP_CREDENTIALS_PROVIDER_IDENTIFIER) | ||
| .withProperty("credentials-provider.http.endpoint", httpEndpointUri) | ||
| .withProperty("credentials-provider.http.headers", headerConfigAsString) | ||
| .withProperty("credentials-provider.http.cache-size", "2") | ||
| .withProperty("credentials-provider.http.cache-ttl", "10m") | ||
| .addModule(binder -> binder.bind(TestHttpCredentialsServlet.class).toInstance(httpCredentialsServlet)); | ||
| } | ||
| } | ||
|
|
||
| protected static TestingHttpServer createTestingHttpCredentialsServer(Servlet servlet) | ||
| throws IOException | ||
| { | ||
| NodeInfo nodeInfo = new NodeInfo("test"); | ||
| HttpServerConfig config = new HttpServerConfig().setHttpPort(0); | ||
| HttpServerInfo httpServerInfo = new HttpServerInfo(config, nodeInfo); | ||
| return new TestingHttpServer(httpServerInfo, nodeInfo, config, servlet, ImmutableMap.of()); | ||
| } | ||
| } |
24 changes: 24 additions & 0 deletions
24
.../src/test/java/io/trino/aws/proxy/server/credentials/http/TestHttpCredentialsServlet.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| /* | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package io.trino.aws.proxy.server.credentials.http; | ||
|
|
||
| import jakarta.servlet.Servlet; | ||
|
|
||
| public interface TestHttpCredentialsServlet | ||
| extends Servlet | ||
| { | ||
| int getRequestCount(); | ||
|
|
||
| void resetRequestCount(); | ||
| } |
109 changes: 109 additions & 0 deletions
109
.../test/java/io/trino/aws/proxy/server/credentials/http/TestHttpCredentialsServletImpl.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,109 @@ | ||
| /* | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package io.trino.aws.proxy.server.credentials.http; | ||
|
|
||
| import com.google.common.collect.ImmutableList; | ||
| import com.google.common.collect.ImmutableMap; | ||
| import io.airlift.json.ObjectMapperProvider; | ||
| import io.trino.aws.proxy.server.testing.TestingIdentity; | ||
| import io.trino.aws.proxy.spi.credentials.Credential; | ||
| import io.trino.aws.proxy.spi.credentials.Credentials; | ||
| import jakarta.servlet.http.HttpServlet; | ||
| import jakarta.servlet.http.HttpServletRequest; | ||
| import jakarta.servlet.http.HttpServletResponse; | ||
|
|
||
| import java.io.IOException; | ||
| import java.util.Map; | ||
| import java.util.Optional; | ||
| import java.util.concurrent.atomic.AtomicInteger; | ||
|
|
||
| import static jakarta.ws.rs.core.MediaType.APPLICATION_JSON; | ||
|
|
||
| public class TestHttpCredentialsServletImpl | ||
| extends HttpServlet implements TestHttpCredentialsServlet | ||
| { | ||
| public static final String DUMMY_EMULATED_ACCESS_KEY = "test-emulated-access-key"; | ||
| public static final String DUMMY_EMULATED_SECRET_KEY = "test-emulated-secret-key"; | ||
| public static final String DUMMY_REMOTE_ACCESS_KEY = "test-remote-access-key"; | ||
| public static final String DUMMY_REMOTE_SECRET_KEY = "test-remote-secret-key"; | ||
|
|
||
| private final Map<String, String> expectedHeaders; | ||
| private final AtomicInteger requestCounter; | ||
|
|
||
| public TestHttpCredentialsServletImpl(Map<String, String> expectedHeaders) | ||
| { | ||
| this.expectedHeaders = ImmutableMap.copyOf(expectedHeaders); | ||
| this.requestCounter = new AtomicInteger(); | ||
| } | ||
|
|
||
| @Override | ||
| protected void doGet(HttpServletRequest request, HttpServletResponse response) | ||
| throws IOException | ||
| { | ||
| if (!validateRequestHeaders(request, response)) { | ||
| return; | ||
| } | ||
| requestCounter.addAndGet(1); | ||
|
|
||
| Optional<String> sessionToken = Optional.ofNullable(request.getParameter("sessionToken")); | ||
| String emulatedAccessKey = request.getPathInfo().substring(1); | ||
| // The session token in the request is legal if it is either: | ||
| // - Not present | ||
| // - Matching our test logic: it should be equal to the access-key + "-token" | ||
| boolean isLegalSessionToken = sessionToken | ||
| .map(presentSessionToken -> "%s-token".formatted(emulatedAccessKey).equals(presentSessionToken)) | ||
| .orElse(true); | ||
| if (!isLegalSessionToken) { | ||
| response.setStatus(HttpServletResponse.SC_NOT_FOUND); | ||
| return; | ||
| } | ||
| switch (emulatedAccessKey) { | ||
| case DUMMY_EMULATED_ACCESS_KEY -> { | ||
| Credential emulated = new Credential(DUMMY_EMULATED_ACCESS_KEY, DUMMY_EMULATED_SECRET_KEY, sessionToken); | ||
| Credential remote = new Credential(DUMMY_REMOTE_ACCESS_KEY, DUMMY_REMOTE_SECRET_KEY); | ||
| Credentials credentials = new Credentials(emulated, Optional.of(remote), Optional.empty(), Optional.of(new TestingIdentity("test-username", ImmutableList.of(), "xyzpdq"))); | ||
| String jsonCredentials = new ObjectMapperProvider().get().writeValueAsString(credentials); | ||
| response.setContentType(APPLICATION_JSON); | ||
| response.getWriter().print(jsonCredentials); | ||
| } | ||
| case "incorrect-response" -> { | ||
| response.getWriter().print("incorrect response"); | ||
| } | ||
| default -> response.setStatus(HttpServletResponse.SC_NOT_FOUND); | ||
| } | ||
| } | ||
|
|
||
| protected boolean validateRequestHeaders(HttpServletRequest request, HttpServletResponse response) | ||
| { | ||
| for (Map.Entry<String, String> expectedHeader : expectedHeaders.entrySet()) { | ||
| if (!expectedHeader.getValue().equals(request.getHeader(expectedHeader.getKey()))) { | ||
| response.setStatus(HttpServletResponse.SC_BAD_REQUEST); | ||
| return false; | ||
| } | ||
| } | ||
| return true; | ||
| } | ||
|
|
||
| @Override | ||
| public int getRequestCount() | ||
| { | ||
| return requestCounter.get(); | ||
| } | ||
|
|
||
| @Override | ||
| public void resetRequestCount() | ||
| { | ||
| requestCounter.set(0); | ||
| } | ||
| } |