Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table: Row Action Column Accessibility issues #2887

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

ElishaSamPeterPrabhu
Copy link
Collaborator

@ElishaSamPeterPrabhu ElishaSamPeterPrabhu commented Sep 25, 2024

Description

  • Added a title to the row actions column header.
  • Replaced the cancel icon in the row actions with the cancel_circle icon.

References
Fixes #2886

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Copy link

netlify bot commented Sep 25, 2024

Deploy Preview for moduswebcomponents ready!

Name Link
🔨 Latest commit d680e2e
🔍 Latest deploy log https://app.netlify.com/sites/moduswebcomponents/deploys/66ff6f8c2291080008c66522
😎 Deploy Preview https://deploy-preview-2887--moduswebcomponents.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 24 (🔴 down 2 from production)
Accessibility: 98 (no change from production)
Best Practices: 92 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@coliff
Copy link
Member

coliff commented Sep 25, 2024

compared:
https://deploy-preview-2887--moduswebcomponents.netlify.app/?path=/story/components-table--row-actions
to:
https://moduswebcomponents.netlify.app/?path=/story/components-table--row-actions

Fix looks good!

coliff
coliff previously approved these changes Sep 25, 2024
@prashanth-offcl
Copy link
Collaborator

This PR will have to wait until #2874 is merged.

@@ -56,7 +57,7 @@ export const ModusTableHeader: FunctionalComponent<ModusTableHeaderProps> = ({
/>
);
})}
{rowActions.length > 0 && <th class="sticky-right" style={{ width: `${rowActionsLength}px` }}></th>}
{rowActions.length > 0 && <th class="sticky-right" style={{ width: `${rowActionsLength}px` }}>Row Actions Column</th>}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ElishaSamPeterPrabhu we cannot hardcode this, can you create an optional prop to contain the configurations related to rowActions

rowActionsConfig: {
    header?: string;
    width?: number;
}

@prashanth-offcl prashanth-offcl marked this pull request as draft September 30, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Table: Row Action column Accessibility issues
3 participants