Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[blind] Show blind warning on manual blind #294

Merged

Conversation

spalmer25
Copy link
Collaborator

Currently, on nano device, when the blindsigning option is ON, during a review, if the user clicks on the screen that allows him to blindsign (the 2nd screen), the summary is directly displayed. But we expect to show some warning screen before.

This PR add these warning screens.

@spalmer25 spalmer25 added app::wallet issues relating to the wallet app device::NANOS Issues affecting NANOS device device::NANOSP Issues affecting NANOSP device device::NANOX Issues affecting NANOX device labels Sep 26, 2024
@spalmer25 spalmer25 self-assigned this Sep 26, 2024
@spalmer25 spalmer25 marked this pull request as ready for review September 26, 2024 07:15
Copy link
Collaborator

@ajinkyaraj-23 ajinkyaraj-23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ajinkyaraj-23 ajinkyaraj-23 merged commit bbaa799 into main Sep 26, 2024
138 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app::wallet issues relating to the wallet app device::NANOS Issues affecting NANOS device device::NANOSP Issues affecting NANOSP device device::NANOX Issues affecting NANOX device
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants