TVAULT-3311: Improve the deployment of TrilioVault to OpenStack-Ansible environments by using Ansible to automate as much as possible #343
Conversation
rohit-keshri
commented
Aug 7, 2020
rohit-keshri
commented
|
|
| - name: remove temporary file - sync_static.py | ||
| file: path=/tmp/sync_static.py state=absent | ||
| - restart webserver | ||
| when: ansible_distribution=="Ubuntu" |
There was a problem hiding this comment.
these file copying should get handled by the packaging.
copy will happen only if there is a virtualenv activated for horizon.
There was a problem hiding this comment.
As LXC container using virtual env
| - shell: "{{virtual_env}} && {{PYTHON_VERSION}} {{ MANAGE_FILE }} shell < /tmp/sync_static1.py &> /dev/null" | ||
| args: | ||
| chdir: "{{HORIZON_PATH}}" | ||
| - file: path=/tmp/sync_static1.py state=absent |
There was a problem hiding this comment.
we need to review this approach.
| chdir: /tmp | ||
|
|
||
| - name: Remove /tmp/remove_pip_packages.sh | ||
| file: path="/tmp/remove_pip_packages.sh" state=absent |
There was a problem hiding this comment.
we won't require this. we dont use pip packages anymore
| @@ -4,19 +4,30 @@ | |||
| update_cache: yes | |||
| name: | |||
| - tvault-horizon-plugin | |||
| - python-workloadmgrclient | |||
| - workloadmgrclient | |||
There was a problem hiding this comment.
mentioning wlmclient should not be required. uninstalling horizon-plugin should uninstall all the dependent pkgs.
There was a problem hiding this comment.
workloadmgrclient package removed from code
| update_cache: yes | ||
| name: | ||
| - python3-tvault-horizon-plugin | ||
| - python3-workloadmgrclient-el8 |
There was a problem hiding this comment.
mentioning wlmclient should not be required. uninstalling horizon-plugin should uninstall all the dependent pkgs.
There was a problem hiding this comment.
python3-workloadmgrclient-el8 removed for centos-8
| pip uninstall pip -y | ||
| else | ||
| echo "pip and easy_install not available hence skipping trilio pip package cleanup." | ||
| fi |
There was a problem hiding this comment.
remove_pip_package.sh file removed
