Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address issues with the TriBITS update from PR #11380 #11429

Closed
7 of 9 tasks
bartlettroscoe opened this issue Dec 24, 2022 · 13 comments
Closed
7 of 9 tasks

Address issues with the TriBITS update from PR #11380 #11429

bartlettroscoe opened this issue Dec 24, 2022 · 13 comments
Labels
CLOSED_DUE_TO_INACTIVITY Issue or PR has been closed by the GitHub Actions bot due to inactivity. MARKED_FOR_CLOSURE Issue or PR is marked for auto-closure by the GitHub Actions bot. TriBITS Issues with the TriBITS framework itself, not usage of the TriBITS framework type: bug The primary issue is a bug in Trilinos code or tests

Comments

@bartlettroscoe
Copy link
Member

bartlettroscoe commented Dec 24, 2022

Description

There ware some possible errors caused by the recent snapshot of TriBITS into Trilinos from PR #11380. One definite case was a change in the behavior for disabling a TPL and having that disable downstream TPLs (which broke Albany Trilinos configures where HDF5 was explicitly disabled by they wanted Netcdf enabled, see #11426).

There may be other problems as well.

The revert PR #11428 was created and merged which reverted the merge of PR #11380.

Tasks

@bartlettroscoe bartlettroscoe added TriBITS Issues with the TriBITS framework itself, not usage of the TriBITS framework type: bug The primary issue is a bug in Trilinos code or tests labels Dec 24, 2022
@rppawlo
Copy link
Contributor

rppawlo commented Jan 3, 2023

EMPIRE was also seeing a configure failure similar to what @spdomin noted in #11426 with the tribits push from last week:

02:06:42  Setting up major user options ...
02:06:42  
02:06:42  CMake Error at cmake/tribits/core/package_arch/TribitsGlobalMacros.cmake:744 (message):
02:06:42    Error, Trilinos_ASSERT_MISSING_PACKAGES= 'ON' is set and is no longer
02:06:42    supported! Please set Trilinos_ASSERT_DEFINED_DEPENDENCIES=FATAL_ERROR
02:06:42    instead!
02:06:42  Call Stack (most recent call first):
02:06:42    cmake/tribits/core/package_arch/TribitsProjectImpl.cmake:130 (tribits_define_global_options_and_define_extra_repos)
02:06:42    cmake/tribits/core/package_arch/TribitsProject.cmake:92 (tribits_project_impl)
02:06:42    CMakeLists.txt:144 (TRIBITS_PROJECT)
02:06:42  
02:06:42  
02:06:42  -- Configuring incomplete, errors occurred!

@bartlettroscoe
Copy link
Member Author

@rppawlo, @spdomin,

Responding to above and #11426 (comment) for fatal error on setting Trilinos_ASSERT_MISSING_PACKAGES ...

This change was highlighted in the changelog here

I could bring back support for Trilinos_ASSERT_MISSING_PACKAGES and properly deprecate it with a deprecation warning. That would smooth upgrades. I will look into that. (But then you have to check for cases where the old option and new option are both set and perhaps to inconsistent values.)

@rppawlo
Copy link
Contributor

rppawlo commented Jan 3, 2023

@bartlettroscoe - you don't have to properly deprecate for empire. empire is not setting that flag anywhere. It is being set by the atdm build scripts and needs to be fixed in trilinos:

rppawlo@s1057859 cmake % git grep ASSERT_MISSING
std/atdm/ATDMDevEnvSettings.cmake:ATDM_SET_CACHE(Trilinos_ASSERT_MISSING_PACKAGES ON CACHE BOOL)

@bartlettroscoe
Copy link
Member Author

It is being set by the atdm build scripts and needs to be fixed in trilinos

@rppawlo, that is good to know. (Not sure how that setting got in there.)

@bartlettroscoe
Copy link
Member Author

@spdomin, what configuration of Trilinos is producing the Trilinos_ASSERT_MISSING_PACKAGES error you reported in #11426 (comment)? Is this the Spack configuration?

@spdomin
Copy link
Contributor

spdomin commented Jan 6, 2023

@spdomin, what configuration of Trilinos is producing the Trilinos_ASSERT_MISSING_PACKAGES error you reported in #11426 (comment)? Is this the Spack configuration?

@bartlettroscoe, no, this was my standard Trilinos config using the config file noted in this push: NaluCFD/Nalu@c4f24d4

See line 83 build/do-configTrilinos_release

@bartlettroscoe
Copy link
Member Author

@spdomin, are you okay with the solution to just remove -D Trilinos_ASSERT_MISSING_PACKAGES=OFF from you configure script in NaluCFD/Nalu@c4f24d4?

bartlettroscoe added a commit to bartlettroscoe/TriBITS that referenced this issue Jan 10, 2023
…linos#11429)

I also added a test to make sure it should at least for the case
<Project>_ASSERT_MISSING_PACKAGES=ON.  For the case 'OFF', it just sets INGORE
by default (and should be correct by simple inspection).

See new CHANGLOG entry.
bartlettroscoe added a commit to TriBITSPub/TriBITS that referenced this issue Jan 11, 2023
bartlettroscoe added a commit that referenced this issue Jan 11, 2023
Origin repo remote tracking branch: 'github/master'
Origin repo remote repo URL: 'github = [email protected]:TriBITSPub/TriBITS.git'
Git describe: vera-release-3.5-start-1697-gd0ae49f2

At commit:

commit bf7c58f60f8da7da81972e93bf7e67b3e821c6e2
Author:  Roscoe A. Bartlett <[email protected]>
Date:    Tue Jan 10 16:15:09 2023 -0700
Summary: Bring back deprecated <Project>_ASSERT_MISSING_PACKAGES (#11429)
bartlettroscoe added a commit to bartlettroscoe/Trilinos that referenced this issue Jan 11, 2023
@bartlettroscoe
Copy link
Member Author

@rppawlo, @spdomin, @ikalash, @GrahamBenHarper, @lxmota,

Do any of you want to try to test against the update of TriBITS and Trilinos in the new PR #11458 with Nalu or Albany before this PR gets merged? The issues discovered in the previous TriBITS snapshot merge from PR #11380 should be addressed as listed in above. I will run some ATDM Trilinos builds before I try to merge but I was not going to test against APP codes. (But if there are easy up-to-date instructions on running a smoke test against a branch of Trilinos and the APP's suite against Trilinos 'develop' is clean, then I am willing to give it a try.)

bartlettroscoe added a commit to bartlettroscoe/Trilinos that referenced this issue Jan 11, 2023
…EFINED_DEPENDENCIES (trilinos#11429)

I set the value of Trilinos_ASSERT_DEFINED_DEPENDENCIES=SEND_ERROR so that if
any Trilinos package (including from add-on repos like Drekar) lists undefined
TPLs, then they will see all of the errors instead of just aborting on the
first error.  (That makes the process to fix all of the errors go faster.)
trilinos-autotester added a commit that referenced this issue Jan 19, 2023
…ot-2022-12-12-again

Automatically Merged using Trilinos Pull Request AutoTester
PR Title: Bring back TriBITS snapshot from PR #11380 and address issues (#11429)
PR Author: bartlettroscoe
@bartlettroscoe
Copy link
Member Author

@rppawlo, @spdomin, @ikalash, @GrahamBenHarper, @lxmota,

FYI: PR #11458 just merged. Please comment here if you see any problems with your integration testing of Trilinos 'develop' with you codes.

@GrahamBenHarper
Copy link
Contributor

GrahamBenHarper commented Jan 19, 2023

@bartlettroscoe it looks like the TriBITS configure still doesn't pick up the MueLu/Xpetra dependency on Thyra properly for #11425. I'm letting it run a clean build again, but I suspect since the list of enabled packages has not changed and the build logic has not changed, the result is the same. Interestingly, it looks like it sets the Xpetra dependencies twice in a row.

Edit: the build indeed failed in the same place

-- Setting ThyraCore_ENABLE_TeuchosCore=ON since Trilinos_ENABLE_ThyraCore=ON AND Trilinos_ENABLE_TeuchosCore=ON
-- Setting ThyraCore_ENABLE_TeuchosParameterList=ON since Trilinos_ENABLE_ThyraCore=ON AND Trilinos_ENABLE_TeuchosParameterList=ON
-- Setting ThyraCore_ENABLE_TeuchosComm=ON since Trilinos_ENABLE_ThyraCore=ON AND Trilinos_ENABLE_TeuchosComm=ON
-- Setting ThyraCore_ENABLE_TeuchosNumerics=ON since Trilinos_ENABLE_ThyraCore=ON AND Trilinos_ENABLE_TeuchosNumerics=ON
-- Setting ThyraCore_ENABLE_RTOp=ON since Trilinos_ENABLE_ThyraCore=ON AND Trilinos_ENABLE_RTOp=ON
-- Setting ThyraTpetraAdapters_ENABLE_ThyraCore=ON since Trilinos_ENABLE_ThyraTpetraAdapters=ON AND Trilinos_ENABLE_ThyraCore=ON
-- Setting ThyraTpetraAdapters_ENABLE_Tpetra=ON since Trilinos_ENABLE_ThyraTpetraAdapters=ON AND Trilinos_ENABLE_Tpetra=ON
-- Setting Xpetra_ENABLE_Teuchos=ON since Trilinos_ENABLE_Xpetra=ON AND Trilinos_ENABLE_Teuchos=ON
-- Setting Xpetra_ENABLE_KokkosCore=ON since Trilinos_ENABLE_Xpetra=ON AND Trilinos_ENABLE_KokkosCore=ON
-- Setting Xpetra_ENABLE_KokkosContainers=ON since Trilinos_ENABLE_Xpetra=ON AND Trilinos_ENABLE_KokkosContainers=ON
-- Setting Xpetra_ENABLE_Tpetra=ON since Trilinos_ENABLE_Xpetra=ON AND Trilinos_ENABLE_Tpetra=ON
-- Setting Xpetra_ENABLE_KokkosKernels=ON since Trilinos_ENABLE_Xpetra=ON AND Trilinos_ENABLE_KokkosKernels=ON
-- NOT setting Xpetra_ENABLE_Thyra=ON since Thyra is NOT enabled at this point!
-- Setting Xpetra_ENABLE_BLAS=ON since Trilinos_ENABLE_Xpetra=ON AND TPL_ENABLE_BLAS=ON
-- Setting Xpetra_ENABLE_LAPACK=ON since Trilinos_ENABLE_Xpetra=ON AND TPL_ENABLE_LAPACK=ON
-- NOTE: Xpetra_ENABLE_Tpetra=ON is already set!
-- NOTE: Xpetra_ENABLE_KokkosKernels=ON is already set!
-- NOT setting Xpetra_ENABLE_Thyra=ON since Thyra is NOT enabled at this point!
...
-- NOT setting MueLu_ENABLE_Thyra=ON since Thyra is NOT enabled at this point!
-- Setting MueLu_ENABLE_ThyraTpetraAdapters=ON since Trilinos_ENABLE_MueLu=ON AND Trilinos_ENABLE_ThyraTpetraAdapters=ON

jmgate pushed a commit to tcad-charon/Trilinos that referenced this issue Jan 21, 2023
…s:develop' (33d2b9b).

* trilinos-develop:
  FMT: new version, nvidia fixes
  Fix shadowing warning
  IOSS: Fix shadowed variable warnings
  IOSS: Remove some IOSS_MAYBE_UNUSED until can determine why failing
  IOSS: Remove some IOSS_MAYBE_UNUSED until can determine why failing
  IOSS: lib{fmt} - revert unintended removal
  SEACAS: Tribits update
  IOSS: Multiple changes
  SEACAS: General changes
  SEACAS: Tribits update
  SEACAS: Add pragma once instead of include guards
  ATDM: Replace Trilinos_ASSERT_MISSING_PACKAGES with Trilinos_ASSERT_DEFINED_DEPENDENCIES (trilinos#11429)
  Automatic snapshot commit from tribits at bf7c58f6
  Revert "Revert "TriBITS Snapshot 2022-12-12 working toward TriBITSPub/TriBITS#63""
jmgate pushed a commit to tcad-charon/Trilinos that referenced this issue Jan 21, 2023
…s:develop' (33d2b9b).

* trilinos-develop:
  FMT: new version, nvidia fixes
  Fix shadowing warning
  IOSS: Fix shadowed variable warnings
  IOSS: Remove some IOSS_MAYBE_UNUSED until can determine why failing
  IOSS: Remove some IOSS_MAYBE_UNUSED until can determine why failing
  IOSS: lib{fmt} - revert unintended removal
  SEACAS: Tribits update
  IOSS: Multiple changes
  SEACAS: General changes
  SEACAS: Tribits update
  SEACAS: Add pragma once instead of include guards
  ATDM: Replace Trilinos_ASSERT_MISSING_PACKAGES with Trilinos_ASSERT_DEFINED_DEPENDENCIES (trilinos#11429)
  Automatic snapshot commit from tribits at bf7c58f6
  Revert "Revert "TriBITS Snapshot 2022-12-12 working toward TriBITSPub/TriBITS#63""
@bartlettroscoe
Copy link
Member Author

@bartlettroscoe it looks like the TriBITS configure still doesn't pick up the MueLu/Xpetra dependency on Thyra properly for #11425.

Okay, let me give it another try to reproduce this failure.

Copy link

This issue has had no activity for 365 days and is marked for closure. It will be closed after an additional 30 days of inactivity.
If you would like to keep this issue open please add a comment and/or remove the MARKED_FOR_CLOSURE label.
If this issue should be kept open even with no activity beyond the time limits you can add the label DO_NOT_AUTOCLOSE.
If it is ok for this issue to be closed, feel free to go ahead and close it. Please do not add any comments or change any labels or otherwise touch this issue unless your intention is to reset the inactivity counter for an additional year.

@github-actions github-actions bot added the MARKED_FOR_CLOSURE Issue or PR is marked for auto-closure by the GitHub Actions bot. label Feb 24, 2024
Copy link

This issue was closed due to inactivity for 395 days.

@github-actions github-actions bot added the CLOSED_DUE_TO_INACTIVITY Issue or PR has been closed by the GitHub Actions bot due to inactivity. label Mar 27, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLOSED_DUE_TO_INACTIVITY Issue or PR has been closed by the GitHub Actions bot due to inactivity. MARKED_FOR_CLOSURE Issue or PR is marked for auto-closure by the GitHub Actions bot. TriBITS Issues with the TriBITS framework itself, not usage of the TriBITS framework type: bug The primary issue is a bug in Trilinos code or tests
Projects
Development

No branches or pull requests

4 participants