Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring back deprecated <Project>_ASSERT_MISSING_PACKAGES (trilinos/Trilinos#11429) #559

Merged

Conversation

bartlettroscoe
Copy link
Member

See new CHANGLOG entry and git commit message.

Addresses part of trilinos/Trilinos#11429

…linos#11429)

I also added a test to make sure it should at least for the case
<Project>_ASSERT_MISSING_PACKAGES=ON.  For the case 'OFF', it just sets INGORE
by default (and should be correct by simple inspection).

See new CHANGLOG entry.
Copy link
Collaborator

@rabartlett1972 rabartlett1972 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Allow to merge and set up a post-merge review

Copy link
Collaborator

@KyleFromKitware KyleFromKitware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants