Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eliminate all ForTrilinos warnings #185

Open
aprokop opened this issue Dec 18, 2017 · 6 comments
Open

Eliminate all ForTrilinos warnings #185

aprokop opened this issue Dec 18, 2017 · 6 comments

Comments

@aprokop
Copy link
Collaborator

aprokop commented Dec 18, 2017 •
edited
Loading

Once that's done, add -Werror.
@tjfulle
Copy link
Collaborator

tjfulle commented Dec 18, 2017

It’s really too bad any meaningful warnings get lost In a sea of teuchos warnings...

@aprokop
Copy link
Collaborator Author

aprokop commented Dec 18, 2017

I actually don't see any Teuchos warnings from our builds, for instance here.

@tjfulle
Copy link
Collaborator

tjfulle commented Dec 18, 2017

On my machine I have a sea of warnings about throwing from destructor. How do I rid myself of those?

@aprokop
Copy link
Collaborator Author

aprokop commented Dec 18, 2017

On my machine I have a sea of warnings about throwing from destructor. How do I rid myself of those?

It could be that the reason we don't see them at the moment is due to not enabling a lot of flags. I don't know of a robust solution do disable warnings only for some Trilinos packages, which is super annoying.

@aprokop aprokop changed the title Eliminate all warnings Eliminate all ForTrilinos warnings Dec 18, 2017
@aprokop
Copy link
Collaborator Author

aprokop commented Dec 21, 2017

On my machine I have a sea of warnings about throwing from destructor. How do I rid myself of those?

Apparently, the only thing you needed to do is to post to ForTrilinos about it, and now they're being addressed.

@sethrj
Copy link
Collaborator

sethrj commented Mar 8, 2018

I've eliminated the remaining SWIG warnings in #220 .

@sethrj sethrj mentioned this issue Mar 21, 2018
Closed
@sethrj sethrj mentioned this issue Feb 5, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sethrj @tjfulle @aprokop