Fix emulator build on MacOS #4242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cepetr
added
the
emulator only
[no changelog]
cepetr
force-pushed
the
cepetr/macos-build-fix
branch
from
0ae17ed
to
6096b7c
Compare
instead of reverting, how about this? 93e13f5 |
cepetr
force-pushed
the
cepetr/macos-build-fix
branch
2 times, most recently
from
e687aa9
to
bf375b1
Compare
cepetr
force-pushed
the
cepetr/macos-build-fix
branch
from
bf375b1
to
db89004
Compare
so that we can compile it with clang [no changelog]
[no changelog]
[no changelog]
cepetr
force-pushed
the
cepetr/macos-build-fix
branch
from
db89004
to
9931941
Compare
matejcik
reviewed
Oct 3, 2024
matejcik
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the emulator build on macOS.
reboot()function was renamed toreboot_device()to avoid a collision with the function of the same name inunitstd.h.2) The emulator is now using the libcsnprintfinstead of the minimalisticmini_snprintfagain (I reverted the change introduced in #4188).Fixed
mini_printf()implementation, so it can be compiled on MacOS.Added string parameter
_Static_assertinimage.c. Looks like the macOS compiler has problem with single parameter version outside a function body.Final testing revealed several bugs that prevented the RSOD screen from being drawn in the emulator, so I fixed them as well.