fix(core): restore ellipsis functionality on TR #4216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
So the only change is for T3B1 in passphrase entry? |
TychoVrahe
approved these changes
Sep 25, 2024
There was a problem hiding this comment.
Ack.
The pin input is also affected, but a bit differently, it doesn't show the dots it just limits number of characters rendered. The difference is that PinEntry uses this ChangingText with without_ellipsis called.
The translations fixtures need updating too probably.
matejcik
added
the
translations
|
Shouldn't we unify the behavior? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4121 broke a little thing that Rust's unused variable detection told me about
for passphrase, this PR restores to pre-4121 state
the PIN confuses me a little, it might be more broken than what this single change affected?