Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

T3B1: fix coin support info and translations generation #4147

Merged
merged 9 commits into from
Sep 11, 2024
Merged

T3B1: fix coin support info and translations generation #4147

merged 9 commits into from
Sep 11, 2024

Conversation

matejcik
Copy link
Contributor

@matejcik matejcik commented Sep 2, 2024

also flip CI to use T3B1 everywhere that we previously used T2B1.

to be discussed: do we also want to run T2B1 in some limited capacity?
(e.g., yes to UI tests, no to translations?)

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 2, 2024 •
edited
Loading

legacy UI changes device test(screens) main(screens)

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 2, 2024 •
edited
Loading

core UI changes device test click test persistence test
T2T1 Model T test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T3B1 Safe 3 test(screens) main(screens) test(screens) main(screens) 2724
T3T1 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
All main(screens)

@matejcik
Copy link
Contributor Author

matejcik commented Sep 2, 2024

builds on top of #4148

@matejcik matejcik changed the base branch from main to matejcik/coins-t3b1-only September 2, 2024 13:24
@matejcik matejcik marked this pull request as ready for review September 2, 2024 13:24
Base automatically changed from matejcik/coins-t3b1-only to main September 3, 2024 08:35
@matejcik matejcik force-pushed the matejcik/coins-t3b1 branch 2 times, most recently from 5009b34 to fa00575 Compare September 3, 2024 10:51
@mmilata
Copy link
Member

mmilata commented Sep 3, 2024

do we also want to run T2B1 in some limited capacity?

I wonder if we should build firmware images for both? At least nightly.

UI tests don't seem very important.

mmilata
mmilata approved these changes Sep 4, 2024
View reviewed changes
Copy link
Member

@mmilata mmilata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@matejcik matejcik added the translations Put this label on a PR to run tests in all languages label Sep 10, 2024
@matejcik
tests: rework tutorial tests
c9d6336 
complicated flows that _do not accomplish results_ do not belong into
device_tests, so I moved them to click_tests and added stronger assert
system
@matejcik
chore(tests): upgrade T2B1 to T3B1 for UI master-comparison
974156b
@matejcik matejcik force-pushed the matejcik/coins-t3b1 branch 2 times, most recently from 75066d4 to 8d0cf6a Compare September 11, 2024 08:41
@matejcik
feat(tests): use trezorlib's builtin model list to fetch the pipelines
ad47a25 
this includes D001 / D002, that probably doesn't matter
@matejcik
feat(tests): flip the default service for update_fixtures.py ci to …
e90601b 
…github

now that we don't really use gitlab anymore
@matejcik matejcik removed the translations Put this label on a PR to run tests in all languages label Sep 11, 2024
@matejcik matejcik self-assigned this Sep 11, 2024
@matejcik matejcik merged commit eda8c72 into main Sep 11, 2024
134 of 135 checks passed
@matejcik matejcik deleted the matejcik/coins-t3b1 branch September 11, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmilata mmilata mmilata approved these changes

Assignees

@matejcik matejcik

Labels
None yet
Projects
Firmware
Status: ✅ Approved
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matejcik @mmilata