Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core/mercury): show remaining shares #4142

Merged
merged 1 commit into from
Sep 3, 2024
Merged

fix(core/mercury): show remaining shares #4142

merged 1 commit into from
Sep 3, 2024

Conversation

obrusvit
Copy link
Contributor

@obrusvit obrusvit commented Aug 30, 2024 •
edited
Loading

This commit enables showing "Remaining shares" from the context menu during recovery process. This is only shown during super-shamir.
emu00000000 emu00000001 emu00000002

TODO:

  • input flows and BRs misalignment - some tests might hang
  • the Footer in Remaining shares window should work somewhat similar to the footer in chose credentials of FIDO2
    • Suggestion: merging this functionality without the Footer for now. Deploying the Footer later.

@obrusvit obrusvit added the T3T1 label Aug 30, 2024
@obrusvit obrusvit added this to the T3T1 milestone Aug 30, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 30, 2024 •
edited
Loading

core UI changes device test click test persistence test
T2T1 Model T test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T2B1 Safe 3 test(screens) main(screens) test(screens) main(screens) 2724
T3T1 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
All main(screens)

@obrusvit obrusvit force-pushed the obrusvit/ui-t3t1/remaining-shares-info branch 3 times, most recently from 02f2c31 to d805a1a Compare September 2, 2024 20:33
@obrusvit obrusvit self-assigned this Sep 2, 2024
@obrusvit obrusvit marked this pull request as ready for review September 2, 2024 21:06
obrusvit
obrusvit commented Sep 3, 2024
View reviewed changes
tests/input_flows_helpers.py Outdated Show resolved Hide resolved
mmilata
mmilata reviewed Sep 3, 2024
View reviewed changes
Copy link
Member

@mmilata mmilata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two nits but overall looking good

tests/input_flows_helpers.py Outdated Show resolved Hide resolved
core/src/trezor/ui/layouts/tt/recovery.py Outdated Show resolved Hide resolved
@obrusvit obrusvit added the translations Put this label on a PR to run tests in all languages label Sep 3, 2024
@obrusvit
fix(core/mercury): show remaining shares
9736cff 
This commit enables showing "Remaining shares" from the context menu
during recovery process. This is only shown during super-shamir.
@obrusvit obrusvit force-pushed the obrusvit/ui-t3t1/remaining-shares-info branch from 3a03e8b to 9736cff Compare September 3, 2024 10:56
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 3, 2024

legacy UI changes device test(screens) main(screens)

@obrusvit obrusvit merged commit c5f9fad into main Sep 3, 2024
119 of 121 checks passed
@obrusvit obrusvit deleted the obrusvit/ui-t3t1/remaining-shares-info branch September 3, 2024 12:20
@bosomt
Copy link

bosomt commented Sep 4, 2024

QA OK

tedsed by recovery of super shamir /3 shares/

Info:

  • Suite version: desktop 24.9.1 (ce0f589a4863ec711ca3f0e5677accb2d0c06cd2)
  • Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) TrezorSuite/24.9.1 Chrome/124.0.6367.243 Electron/30.3.1 Safari/537.36
  • OS: MacIntel
  • Screen: 1512x982
  • Device: Trezor T3T1 2.8.2 regular (revision d7e1f0f)
  • Transport: BridgeTransport 3.0.0

@obrusvit obrusvit mentioned this pull request Sep 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmilata mmilata mmilata approved these changes

Assignees

@obrusvit obrusvit

Labels
T3T1 translations Put this label on a PR to run tests in all languages
Projects
Firmware
Status: ✅ Approved
Milestone
T3T1
Development

Successfully merging this pull request may close these issues.
3 participants
@obrusvit @bosomt @mmilata