New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[draft] THP #4050

Draft

M1nd3r wants to merge 70 commits into main from M1nd3r/thp

+19,772 −6,736

Contributor

M1nd3r commented Jul 22, 2024

No description provided.

M1nd3r requested a review from onvej-sl

July 22, 2024 11:42

github-actions bot commented Jul 22, 2024 •

edited

Loading

core UI changes	device test	click test	persistence test
T2T1 Model T	test(screens) main(screens)	test(screens) main(screens)	test(screens) main(screens)
T3B1 Safe 3	test(screens) main(screens)	test(screens) main(screens)	test(screens) main(screens)
T3T1 Safe 5	test(screens) main(screens)	test(screens) main(screens)	test(screens) main(screens)
All	main(screens)

M1nd3r self-assigned this

onvej-sl reviewed

View reviewed changes

core/src/trezor/wire/thp/crypto.py Show resolved Hide resolved

onvej-sl reviewed

View reviewed changes

core/src/trezor/wire/thp/crypto.py Show resolved Hide resolved

onvej-sl reviewed

View reviewed changes

core/src/trezor/wire/thp/crypto.py Show resolved Hide resolved

onvej-sl reviewed

View reviewed changes

core/src/trezor/wire/thp/crypto.py Show resolved Hide resolved

onvej-sl reviewed

View reviewed changes

core/src/trezor/wire/thp/crypto.py Show resolved Hide resolved

onvej-sl reviewed

View reviewed changes

core/src/trezor/wire/thp/received_message_handler.py Outdated Show resolved Hide resolved

onvej-sl reviewed

View reviewed changes

core/src/trezor/wire/thp/received_message_handler.py Outdated Show resolved Hide resolved

onvej-sl reviewed

View reviewed changes

core/src/trezor/wire/thp/cpace.py Outdated Show resolved Hide resolved

onvej-sl reviewed

View reviewed changes

core/src/trezor/wire/thp/channel.py Outdated Show resolved Hide resolved

onvej-sl reviewed

View reviewed changes

core/src/trezor/wire/thp/pairing_context.py Outdated Show resolved Hide resolved

onvej-sl reviewed

View reviewed changes

core/src/trezor/wire/thp/channel.py Outdated Show resolved Hide resolved

Contributor

onvej-sl commented Jul 26, 2024

Well done, @M1nd3r !

I reviewed the usage of cryptography and compliance with our documentation of the secure channel layer.

M1nd3r force-pushed the M1nd3r/thp branch from e402934 to 98c4f11 Compare

October 10, 2024 10:44

github-actions bot commented Oct 10, 2024 •

edited

Loading

legacy UI changes	device test(screens) main(screens)

M1nd3r changed the title ~~[draft] Review of cryptography in the new THP~~ [draft] THP

M1nd3r force-pushed the M1nd3r/thp branch 11 times, most recently from db0881c to 641611b Compare

November 19, 2024 19:24

M1nd3r force-pushed the M1nd3r/thp branch from 641611b to 39062a7 Compare

November 20, 2024 14:26

M1nd3r added 23 commits

November 27, 2024 12:25


          fix(python): fix test_msg_backup_device interruption

a8aa499

[no changelog]


          fix(python): test_session_id_and_passphrase device test

6ffb0d6

[no changelog]


          fixup! fix(python): fix device tests for test_session [no changelog]

b1a1429


          fixup! fixup! fix(python): fix device tests for test_session [no chan…

a02d08e

…gelog]


          fix(python): fix test_autolock

9a63d61

[no changelog]


          test(python): fix test_protection_levels device tests

5eecbc2

[no changelog]


          test(python): fix text_basic device test

3d37dd4

[no changelog]


          test(python): fix test_debuglink device test

1eae048

[no changelog]


          test(python): fix test_msg_applysettings device tests

929baea

 [no changelog]


          test(python): fix click_tests

22649ac

[no changelog]


          test(python): fix upgrade_tests (partially)

77ca526

[no changelog]


          test(python): fix persistence_tests

c7e857d

[no changelog]


          fix: remove print

e455f42

[no changelog]


          test: fix style

7c8382f

[no changelog]


          fix: return Bridge to all_transports by default

b98120b

[no changelog]


          test(python): fix device tests

4102aa8


          fix(trezorlib): fix cli commands

7880e0d

[no changelog]


          test: fix conftest setting of language

a1fa49c

[no changelog]


          test: fix style

0f995e5


          fix(trezorlib): fix style

43c8e2e


          test: fix client.reset_debug_features for codec

ca9436e

[no changelog]


          test: fix obtaining sessions with passphrase and setting language

f589062

[no changelog]


          fix(core): update structure of common seed so it works on BTC_ONLY

5b21b90

[no changelog]

M1nd3r force-pushed the M1nd3r/thp branch from 925bbee to 5b21b90 Compare

November 27, 2024 11:27

M1nd3r added 6 commits

November 27, 2024 12:53


          test: try fix pin callback

1e7d967


          test: fix test_protection_levels device test

179de14

[no changelog]


          test: allow session to be locked by default

46ba583

[no changelog]


          test: fix legacy test_firmware_upgrades device tests

c595ecc

[no changelog]


          test: try fix test_firmware_upgrades on legacy

a2a01b9

[no changelog]


          test: fix handling of PASSPHRASE_ON_DEVICE

49f7626

[no changelog]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

onvej-sl onvej-sl left review comments

prusnak Awaiting requested review from prusnak prusnak will be requested when the pull request is marked ready for review prusnak is a code owner

matejcik Awaiting requested review from matejcik matejcik will be requested when the pull request is marked ready for review matejcik is a code owner

andrewkozlik Awaiting requested review from andrewkozlik andrewkozlik will be requested when the pull request is marked ready for review andrewkozlik is a code owner

At least 1 approving review is required to merge this pull request.

Labels

None yet