Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add THP credential manager #3862

Merged
merged 4 commits into from
Oct 9, 2024
Merged

Add THP credential manager #3862

merged 4 commits into from
Oct 9, 2024

Conversation

M1nd3r
Copy link
Contributor

@M1nd3r M1nd3r commented May 25, 2024 •
edited
Loading

This PR provides derivation, validation, and invalidation of pairing credential authentication keys.

@M1nd3r M1nd3r self-assigned this May 25, 2024
@M1nd3r M1nd3r added core Trezor Core firmware. Runs on Trezor Model T and T2B1. R&D Research and development team related labels May 25, 2024
@M1nd3r M1nd3r force-pushed the M1nd3r/thp-credential-manager branch from ef94948 to f24173a Compare May 31, 2024 11:29
@M1nd3r M1nd3r requested a review from andrewkozlik May 31, 2024 11:45
@M1nd3r M1nd3r marked this pull request as ready for review May 31, 2024 11:45
@M1nd3r M1nd3r requested a review from matejcik as a code owner May 31, 2024 11:45
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
mmilata
mmilata reviewed Oct 2, 2024
View reviewed changes
Copy link
Member

@mmilata mmilata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, found couple of small things.

common/protob/messages.proto Show resolved Hide resolved
core/SConscript.firmware Outdated Show resolved Hide resolved
core/SConscript.unix Outdated Show resolved Hide resolved
core/src/apps/thp/credential_manager.py Show resolved Hide resolved
core/src/apps/thp/credential_manager.py Show resolved Hide resolved
mmilata
mmilata approved these changes Oct 3, 2024
View reviewed changes
Copy link
Member

@mmilata mmilata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please rebase and merge if CI passes.

@M1nd3r M1nd3r force-pushed the M1nd3r/thp-credential-manager branch from 3530e54 to bed3414 Compare October 8, 2024 17:53
@M1nd3r M1nd3r force-pushed the M1nd3r/thp-credential-manager branch from bed3414 to d8a2121 Compare October 8, 2024 21:29
@M1nd3r M1nd3r merged commit c999883 into main Oct 9, 2024
85 checks passed
@M1nd3r M1nd3r deleted the M1nd3r/thp-credential-manager branch October 9, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewkozlik andrewkozlik andrewkozlik left review comments

@mmilata mmilata mmilata approved these changes

@matejcik matejcik Awaiting requested review from matejcik matejcik is a code owner

Assignees

@M1nd3r M1nd3r

Labels
core Trezor Core firmware. Runs on Trezor Model T and T2B1. R&D Research and development team related
Projects
Firmware
Status: ✅ Approved
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@M1nd3r @mmilata @matejcik @andrewkozlik