Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

only allow confirm-less firmware installation of full-trust images #3709

Merged
merged 3 commits into from
Sep 3, 2024
Merged

only allow confirm-less firmware installation of full-trust images #3709

merged 3 commits into from
Sep 3, 2024

Conversation

TychoVrahe
Copy link
Contributor

Applies to empty devices only.

Now even when empty, installing fw without full trust requires user confirmation.

@TychoVrahe TychoVrahe self-assigned this Apr 11, 2024
@TychoVrahe TychoVrahe force-pushed the tychovrahe/bootloader/confirmation branch from 431911f to 996aeca Compare April 12, 2024 20:45
@TychoVrahe TychoVrahe removed the request for review from prusnak April 12, 2024 20:51
@Hannsek Hannsek requested a review from matejcik May 7, 2024 12:01
@TychoVrahe TychoVrahe requested a review from cepetr August 29, 2024 08:47
@cepetr
Copy link
Contributor

cepetr commented Aug 29, 2024

I don't see any problem with this change. Just add a note on how we can simplify the code a bit.

@TychoVrahe TychoVrahe force-pushed the tychovrahe/bootloader/confirmation branch from 996aeca to 7673c3d Compare August 29, 2024 11:41
@TychoVrahe
Copy link
Contributor Author

I added two more commits here:
68398d4 fixes failing repeated upload attempt, cause by one of the previous unreleased PR.

7673c3d fixes vendor header rendering with new_rendering on.

@cepetr please look on these changes too.

@TychoVrahe TychoVrahe requested a review from cepetr August 29, 2024 11:47
cepetr
cepetr requested changes Aug 29, 2024
View reviewed changes
core/embed/bootloader/bootui.c Outdated Show resolved Hide resolved
@TychoVrahe TychoVrahe requested a review from cepetr August 30, 2024 07:50
cepetr
cepetr approved these changes Sep 2, 2024
View reviewed changes
Copy link
Contributor

@cepetr cepetr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@TychoVrahe TychoVrahe force-pushed the tychovrahe/bootloader/confirmation branch from 5197e2b to 7cf7eb5 Compare September 2, 2024 13:00
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 2, 2024

core UI changes device test click test persistence test
T2T1 Model T test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T2B1 Safe 3 test(screens) main(screens) test(screens) main(screens) 2724
T3T1 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
All main(screens)

@TychoVrahe TychoVrahe merged commit 4916470 into main Sep 3, 2024
85 of 86 checks passed
@TychoVrahe TychoVrahe deleted the tychovrahe/bootloader/confirmation branch September 3, 2024 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matejcik matejcik matejcik approved these changes

@cepetr cepetr cepetr approved these changes

Assignees

@TychoVrahe TychoVrahe

Labels
None yet
Projects
Firmware
Status: 🤝 Needs QA
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TychoVrahe @cepetr @matejcik