-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Weaviate #180
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: hsm207 <[email protected]>
Signed-off-by: hsm207 <[email protected]>
Signed-off-by: hsm207 <[email protected]>
Signed-off-by: hsm207 <[email protected]>
Signed-off-by: hsm207 <[email protected]>
Signed-off-by: hsm207 <[email protected]>
Signed-off-by: hsm207 <[email protected]>
Signed-off-by: hsm207 <[email protected]>
Signed-off-by: hsm207 <[email protected]>
Signed-off-by: hsm207 <[email protected]>
Signed-off-by: hsm207 <[email protected]>
Signed-off-by: hsm207 <[email protected]>
|
||
def enable_ltr(self, collection): | ||
"Initializes LTR dependencies for a given collection" | ||
raise NotImplementedError("¯\\_(ツ)_/¯") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This method may go away (TBD). It's currently just a hook to tell the engine to adjust it's configuration if needed to support LTR on the given collection. In the case of Weaviate, I assume the LTR model will be running and invoked outside the engine, so you'll either have it always running (in which enable_ltr
can be a noop) OR you can use enable_ltr
to copy any data/models/config needed into place.
@hsm207 - Awesome to see you working on this. If you have any questions, don't hesitate to reach out. After doing several other implementations, here's a bit of an implementation checklist for key things you'll come across during the implementation: Dockerfile / Docker compose configuration Query functionality: There are some other things like hybrid search (reciprocal rank fusion) that are implemented at the As mentioned in the At any rate, hope that's helpful. Let us know if you have any questions we can assist with! |
Signed-off-by: hsm207 [email protected]