Refactor _do_links and simplify link handling logic
#610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed a whole bunch of duplication and tried to make the function flow much easier to understand
|
This one looked painful lol thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors
_do_links, simplifying it and removing alot of duplicated code.The main point of duplication was around differences in processing inline images/anchors vs reference images and anchors. Both have different ways of extracting the key components of a link: URL, title and end index. However, once these are extracted, they are processed in exactly the same way.
The problem was, the processing code was duplicated across both branches of the if/else statement. This refactor fixes that.
Hopefully this simplification can lay the ground work for potential future improvements