Graceful handling of broken lists when cuddled-lists extra is enabled #578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nicholasserra anything needed on my end? Not sure why the builds above are failing^ |
|
Thanks! Probably a dependency issue with github actions, seems they removed 3.6 or something like that. Will check into it asap |
|
Sorry for the delay. Just fixed CI, if you do a upstream rebase this should be OK now. |
Awesome, thanks. Rebased. Once the workflow run is approved, should be good for a look if the build passes. |
|
LGTM thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #577
Overview
When
"cuddled-lists"extra is passed, if you encounter ASCII art or any invalid list such as:- - - Test, anAssertionErroris thrown due to the inability to parse it as a list and therefore the result text not containing the expected list structure.Changes